1778135 - Add profiler markers for ORB to enable debugging with the profiler.

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P3)

Comment 1

[Sean Feng [:sefeng]]

For profile markers, I am thinking something similar as the setTimeout deferred marker. Then we can tell how much time we spent in the JS validator for each requests, we can give us a sense of the performance impact.

I am also wondering if we should label the ORB blocked requests inside the network tab of profiles. I can imagine this would give us two benefits.

1. It lowers the barrier of reporting ORB broken sites, as users can just collect a profile instead of opening the browser console.
2. It allows us to compare the network requests with ORB and without ORB. We can tell how long do we take to block the requests and how would that compare with it is being loaded normally. I am not sure if we can get some action items from this, but it can give us a sense of the impact of ORB.

Please ignore my requests if you have those already :)

Comment 2

[Andreas Farre [:farre]]

I think I have those already! I'm basing these patches (and the telemetry patches) on the patch for bug 1532644.

Unfortunately D163283 doesn't apply cleanly on central, so I'll have to fiddle a bit to submit to review. But I'll try to put up WIP patches tomorrow.

Comment 3

[Andreas Farre [:farre]]

Attachment: Bug 1778135 - Add profile marker for ORB safelist check. r=sefeng!

Depends on D164568

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fd928c03e0f
Add profile marker for ORB safelist check. r=necko-reviewers,smaug,kershaw

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing build bustage in netwerk/protocol/http/OpaqueResponseUtils.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/c881577e2dc9c274994b214d8a3bf11a2df338b2

Push with failures

Failure log: /builds/worker/checkouts/gecko/netwerk/protocol/http/OpaqueResponseUtils.cpp:385:3: error: control reaches end of non-void function [-Werror=return-type]

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e7378046c8f
Add profile marker for ORB safelist check. r=necko-reviewers,smaug,kershaw

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4e7378046c8f