1778204 - LightweightThemeChild doesn't call update() for non-sidebar parent process documents

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Mike Conley (:mconley) (:⚙️)]

This line here:

https://searchfox.org/mozilla-central/rev/d8225c5b4874325e3024a6857a65eb87e4d6fee9/browser/actors/LightweightThemeChild.jsm#39

assumes that if LightweightThemeChild is running in the parent process, that it's for a sidebar. That bit of gunk that I highlighted does the job for finding the root docShell outerWindowID if the document happens to be a sidebar, but ends up getting at the about:firefoxview outerWindowID for the about:firefoxview case.

We should make it so that LightweightThemeChild returns the outerWindowID of the top-level chrome window in either case.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1778204 - More reliably get at the outerWindowID of the root window in LightweightConsumerChild.jsm. r?Gijs!,sclements!

The other mechanism was working fine for sidebars, but falls over as soon as we
have a normal browser running in the parent process in the main content area.

This will also be helpful if / when we decide to support themes in about:preferences,
about:config, and other parent-process pages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ade0f685c46
More reliably get at the outerWindowID of the root window in LightweightConsumerChild.jsm. r=sclements,dthayer

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1778204 - Add a test for contentTheme for in-process tabs. r?dthayer!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a616ef9e2944
Add a test for contentTheme for in-process tabs. r=dthayer

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6ade0f685c46

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a616ef9e2944