1778209 - :-moz-window-inactive still triggers on window drag on X11 (with titlebar enabled)

Status: ASSIGNED

(Core :: Widget: Gtk, defect)

Description

[Manuel Grießmayr]

Attachment: downloads window on drag.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

I still have this issue on Xubuntu 22.04 on X11 although there was a patch some time ago (see Bug 969322).

When I drag the main window of Thunderbird in version 102, then text in the menu bar changes its color but shouldn't. Also affected are the icons in the left vertical bar and selected emails. There is also the same issue with the download list items in the download window of Firefox 102.

When write in userChrome.css for Thunderbird:
menubar > menu:-moz-window-inactive {
color: red !important;
}

Then the text of the menu bar changes to red but not only when the window is inactive but also on drag. So the -moz-window-inactive seems to get triggered still on drag.

Actual results:

Wrong color on window drag for certain widgets.

Expected results:

Correct color on window drag for certain widgets.

Comment 1

[Manuel Grießmayr]

Attachment: thunderbird window on drag.png

See notes in the images.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Ah, I was going to say that I couldn't repro, but I can repro, only if I enable the titlebar. If I disable it it works fine...

Comment 3

[Manuel Grießmayr]

Maybe related issues: Bug 1497534
this one https://gitlab.gnome.org/GNOME/gtk/-/issues/1395

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: WIP: Bug 1778209 - Make window focus follow GDK_WINDOW_STATE_FOCUSED, not container focus. r=stransky

This seems to work and should be simpler.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Hmm, this seems to cause a bunch of timeouts on automation... https://treeherder.mozilla.org/jobs?repo=try&revision=38051ad06a181e608746e37e6e0633986451b82d

Comment 6

[Manuel Grießmayr]

Any news on this one? Many thanks.