1778249 - Highlight text color is not preserved after pressing Enter in Outlook

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

+++ This bug was initially created as a clone of Bug #1778091 +++

Found in

• Firefox 103 beta 4

Affected versions

• Firefox 102 (RC and ESR)
• Firefox 103 beta 4
• latest Nightly 104.0a1 2022-07-04

Affected platforms

• Win 10 64-bit
• Ubuntu 22
• OSX 10.14.6

Steps to reproduce

1. Access the following website: https://outlook.com/ and login
2. Compose a new email
3. Select Highlight option from the bottom of the new email composition
4. Select a color and start typing
5. Press Enter

Expected result

• Highlight color is preserved after pressing Enter

Actual result

• Highlight color is applied only for the first row, then it changes to the default one

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a67baeba9a658f8650657389f38aa9bc7e2eef07&tochange=f895a0b6c0e3748e11381173b3cd32a7bb8c60dd
• DEBUG : Found commit message: Bug 1730429 - part 2: Delete empty inline elements which become newly empty but preserve the styles for next editing r=m_kato

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1730429

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, the symptom is different from point of view of the DOM tree. However, I found a useful method CopyLastEditableChildStylesWithTransaction which is used by HandleInsertParagraphInListItemElement and it fixes both bug 1778091 and this.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This should've been fixed by the patch for bug 1778091.

Comment 4

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed across platforms using Firefox 104 beta 5.