Closed Bug 1778313 Opened 3 years ago Closed 3 years ago

Make sure the "probe-scraper push model" works with multiple projects in the same repo

Categories

(Data Platform and Tools Graveyard :: Glean Platform, enhancement)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Dexter, Unassigned)

Details

With the project in bug 1778196, we're starting to deploy multiple glean apps from within the same repository. We should make sure the probe-scrape action behaves as expected in these cases.

:relud, will the action automatically pick up the right app id?

I tried to understand this myself but i could not find the source code from the cloud function referenced here. Should we add a comment in the code to mention where the source lives?

Flags: needinfo?(dthorn)

we already deploy multiple glean apps from the same repository (for instance https://github.com/mozilla-mobile/android-components), and match git branches to determine whether to deploy each app for a given git url.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(dthorn)
Resolution: --- → FIXED

Thanks for clarifying :relud. I'd love to understand this a bit more.

Rally has multiple projects in their monorepo, e.g. the attention stream, their web platfor. They both need to be deployed and be independent of each other. Would we need to change the workflow?

Flags: needinfo?(dthorn)

no changes are needed, they are both handled correctly in push mode from the single workflow.

Flags: needinfo?(dthorn)

(In reply to Daniel Thorn [:relud] from comment #3)

no changes are needed, they are both handled correctly in push mode from the single workflow.

Thanks

Product: Data Platform and Tools → Data Platform and Tools Graveyard
You need to log in before you can comment on or make changes to this bug.