Closed Bug 1778457 Opened 2 years ago Closed 2 years ago

Strict mode should also enable query param stripping in PBM

Categories

(Core :: Privacy: Anti-Tracking, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: pbz, Assigned: timhuang)

References

Details

Attachments

(1 file)

We can do this by adding two new keywords for qpsPBM here: https://searchfox.org/mozilla-central/rev/284187d0a7130d21042beeff0af0627c8e68cacc/browser/app/profile/firefox.js#1857-1859 similar how we did it for cookieBehavior.

Assignee: nobody → tihuang
Status: NEW → ASSIGNED
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc7595f1a39a
Enable query parameter stripping in Private Browsing Mode if ETP strict is enabled. r=anti-tracking-reviewers,bvandersloot
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

Comment on attachment 9285188 [details]
Bug 1778457 - Enable query parameter stripping in Private Browsing Mode if ETP strict is enabled. r?#anti-tracking-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: The URL Query Stripping won't be enabled in private browsing mode if ETP strict mode is enabled. And we should enable URL Query Stripping in all windows if ETP strict mode is on.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch makes the ETP strict mode to flip the pref for the URL query stripping in private windows. And the pref will only be enabled if ETP strict mode is enabled. Therefore, the risk is low.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9285188 - Flags: approval-mozilla-beta?

Comment on attachment 9285188 [details]
Bug 1778457 - Enable query parameter stripping in Private Browsing Mode if ETP strict is enabled. r?#anti-tracking-reviewers

Rejecting beta uplift request.
The 103 beta cycle ended last week. The last beta (103.0b9) build on Thursday 2022-07-14.
Since this is not a new regression in 103, it's too late to take this patch - it will ride the train with 104

Attachment #9285188 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: