1778463 - Firefox is pinned to the taskbar even though the "On my taskbar" checkbox is unchecked

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: issue pin.gif

Found in

• Beta 103.0b5

Affected versions

• latest Nightly 104.0a1
• Beta 103.0b5

Affected platforms

• Windows 7 x64

Steps to reproduce

1. Double click on the Firefox Setup.
2. Click on the "Run" button from the dialog.
3. Click on the "Next" button from the installation wizard.
4. Choose the custom installation and hit Next.
5. Leave the default installation path, then hit Next once again.
6. Uncheck the "On my taskbar" checkbox.
7. Finish the installation process.
8. Observe the Win 7 taskbar.

Expected result

• Firefox icon is not pinned to the taskbar.

Actual result

• Firefox icon is pinned to the taskbar.

Regression range

• Not a regression, the bug can be reproduced on the first builds where this feature landed, e.g. Nightly from 2022-06-28.

Additional notes

• This can be reproduced if all Firefox profiles, files are deleted from %appdata%. It did not seem to make any difference if deleting the Mozilla registry files as well.
• We were unable to reproduce this on Win 10 x64 or Win 8.1 x64.

Comment 1

[[e-mail] (:bhearsum)]

This is quite serious as we're violating user intent - I will get a fix up ASAP.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: Bug 1778463: Firefox is pinned to the taskbar even though the "On my taskbar" checkbox is unchecked r?mhowell!

The problem here ended up being that we lose the value of AddTaskBarSC once ExecCodeSegement is called -- which we do anytime we try to set ourselves as the default if the installer was run elevated.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 9284561 [details]
Bug 1778463: Firefox is pinned to the taskbar even though the "On my taskbar" checkbox is unchecked r?mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: In rare cases, we will pin to Firefox to the taskbar even if the user has opted out.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1778463#c0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple installer change that has been verified by myself already.
• String changes made/needed: no
• Is Android affected?: No

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/139ea0c4ca50
Firefox is pinned to the taskbar even though the "On my taskbar" checkbox is unchecked r=mhowell

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/139ea0c4ca50

Comment 6

[Ciprian Georgiu, Desktop QA]

Verified as fixed on latest Nightly 104.0a1 (20220711215641) under Win 7 x64.

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9284561 [details]
Bug 1778463: Firefox is pinned to the taskbar even though the "On my taskbar" checkbox is unchecked r?mhowell!

Approved for 103.0b8, thanks.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0286485b1343

Comment 9

[Ciprian Georgiu, Desktop QA]

The bug is also verified as fixed on latest Beta 103.0b8 under Win 7 x64.