1778504 - API messages.createTag does not accept named colors like "black" as color

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Int]

Steps to reproduce:

Use new API messages.createTag
as described here https://webextension-api.thunderbird.net/en/latest/messages.html?highlight=tag#createtag-key-tag-color

Actual results:

Calling
messenger.messages.createTag("tagkey", "tagname", "black");

fails with error
Error: Type error for parameter color (String "black" must match /^#[0-9a-f]{6}/) for messages.createTag.

Expected results:

The legacy API
Components.classes["@mozilla.org/messenger/tagservice;1"].getService(Components.interfaces.nsIMsgTagService);
accepted named colors like "black" when creating a new tag.

The new API seems to accept only Hex Code #RRGGBB colors.

It should be mentioned in the API documentation
https://webextension-api.thunderbird.net/en/latest/messages.html?highlight=tag#createtag-key-tag-color
what valid entries for the parameter "color" (string) are.

Comment 1

[John Bieling]

Attachment: Bug 1778504 - Improve WebExtension documentation for messageTags and the addressbook. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/30f4a6ac22f0
Improve WebExtension documentation for messageTags and the addressbook. r=mkmelin

Comment 3

[John Bieling]

Comment on attachment 9285467 [details]
Bug 1778504 - Improve WebExtension documentation for messageTags and the addressbook. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Wrong documentation.

Testing completed (on c-c, etc.):
1 day on Daily.

Risk to taking this patch (and alternatives if risky):
Low. This is only changing descriptions in the schema file.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9285467 [details]
Bug 1778504 - Improve WebExtension documentation for messageTags and the addressbook. r=mkmelin

[Triage Comment]

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 103.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/f8df9e49aa4e

Comment 6

[John Bieling]

Comment on attachment 9285467 [details]
Bug 1778504 - Improve WebExtension documentation for messageTags and the addressbook. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Wrong documentation.

Testing completed (on c-c, etc.):
1 day on Beta.

Risk to taking this patch (and alternatives if risky):
Low. This is only changing descriptions in the schema file.

Comment 7

[John Bieling]

Patch applies cleanly to comm-esr102.

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9285467 [details]
Bug 1778504 - Improve WebExtension documentation for messageTags and the addressbook. r=mkmelin

[Triage Comment]
approved for esr102

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.1.0:
https://hg.mozilla.org/releases/comm-esr102/rev/933618954070