Closed Bug 1778519 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34718 - Correct column / column-group block size when fragmented.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34718 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34718
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Correct column / column-group block size when fragmented.

We were effectively just using the block-size of the last table box
fragment as block-size of table columns and column groups, since we were
overwriting results from previous fragments.

Instead, only pass this value when at the last table box fragment, and
correctly exclude table border/padding and initial/final border-spacing.

Bug: 1078927
Change-Id: If6424d961985d84495f388ff8b40aef4b2ce3034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747937
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1021348}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS: 7

Chrome

OK : 1
PASS: 4
FAIL: 3

Safari

OK : 1
PASS: 4
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d714eb9ee36
[wpt PR 34718] - Correct column / column-group block size when fragmented., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.