Closed Bug 1778526 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34729 - Fix async->manual rename in CSS, plus add more testing

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34729 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34729
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Fix async->manual rename in CSS, plus add more testing

When [1] landed, it forgot to change the default CSS for async
to manual. Clearly that indicates a lack of appearance testing,
so this CL adds a WPT for the appearance of pop-ups. I also opened
this issue to discuss the standard styling:

https://github.com/openui/open-ui/issues/561

In the meantime, this CL also refactors all of the test-assumed default
styles for [popup] into popup-styles.css, so that if we change these
in the future it won't be so painful.

This CL also had to add code to the \<selectmenu> positioning algorithm
to remove any margin. I think that's the right way to handle this,
but that does mean developer margin settings on a slotted listbox
won't have any effect. That seems right, but I don't know for sure.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3722345

Bug: 1307772
Change-Id: I4ecf7bee947e90e2abdcedb47b3d38c958abb2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749343
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1021422}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6ff52841391
[wpt PR 34729] - Fix async->manual rename in CSS, plus add more testing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0a12e5d5fcb4
[wpt PR 34729] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c6ff52841391
https://hg.mozilla.org/mozilla-central/rev/0a12e5d5fcb4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.