Closed Bug 1778528 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34731 - Remove special case for <dialog> in fullscreen display:contents code

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34731 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34731
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Remove special case for <dialog> in fullscreen display:contents code

When I added this code [1], I special-cased \<dialog> and ::backdrop.
But according to the spec [2], any top layer element whose display
property is contents should compute to block. This CL makes the
full change.

This changes behavior, but in a very corner-case situation (display:
contents fullscreen elements), and Chromiums code now complies with
the spec. Gecko also agrees with the new behavior. Webkit is difficult
to test because their fullscreen impl is broken. I'm going to monitor
for bug reports in Canary/Dev/Beta and will roll this back out if any
compat issues are found.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3102297
[2] https://fullscreen.spec.whatwg.org/#new-stacking-layer

Bug: 1240701
Change-Id: Id659be8027e257758e7d8ec1b86ec87125b0cb0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749114
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: Khushal Sagar \<khushalsagar@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1021448}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55a5fb6caec9
[wpt PR 34731] - Remove special case for <dialog> in fullscreen display:contents code, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b1d33e1f7c25
[wpt PR 34731] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.