1778530 - [wpt-sync] Sync PR 34725 - Position fragmented cell with bottom padding+alignment correctly.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34725 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34725
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Position fragmented cell with bottom padding+alignment correctly.

Since layout algorithms always add block-end border/padding to the final
fragment size, and then let the fragmentation machinery decide whether
to keep it, or break, we need to notice if it gets removed. Otherwise,
the table-cell alignment code will think that the contents of the cell
are taller than the containing row, and will therefore move bottom (and
center) aligned cells upwards.

To fix this, update intrinsic block-size when trailing border/padding is
removed, and have the algorithms read it back, before applying
table-cell alignment.

I ended up renaming a variable from intrinsic_block_size to
desired_intrinsic_block_size (because FinishFragmentation() still needs
the original intrinsic block-size in some cases). This made the
is_past_end code look strange (it would reset
"desired_intrinsic_block_size" ... so much for desires). So I just
removed that part. It was probably added there for good measure
initially, along with resetting final_block_size (which we have to), but
it doesn't seem necessary.

Bug: 1336024
Change-Id: Ie44e6c47fed196999692bf1608c031237795ddef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747766
Reviewed-by: Alison Maher \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1021558}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0d01aa2f80ba1adc7b38fa508eb2fc7daf1ea12

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-break/table/tall-bottom-aligned-cell-with-bottom-padding.html [wpt.fyi]: FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/774a9e1f8071
[wpt PR 34725] - Position fragmented cell with bottom padding+alignment correctly., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ada8d6bd77e4
[wpt PR 34725] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/774a9e1f8071
https://hg.mozilla.org/mozilla-central/rev/ada8d6bd77e4