Closed Bug 1778622 Opened 2 years ago Closed 2 years ago

Fix IDXGISwapChain3::SetColorSpace1() error handling in DCSurfaceVideo::CallVideoProcessorBlt()

Categories

(Core :: Graphics, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

IDXGISwapChain3::SetColorSpace1() failure handling is wrong.

Chromium does like the following.
https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium

Assignee: nobody → sotaro.ikeda.g
Blocks: 1775288
Summary: Fix IDXGISwapChain3::SetColorSpace1() error handling in DCSurfaceVideo::CallVideoProcessorBlt(). → Fix IDXGISwapChain3::SetColorSpace1() error handling in DCSurfaceVideo::CallVideoProcessorBlt()

(In reply to Sotaro Ikeda [:sotaro away July/11 - July/19] from comment #0)

IDXGISwapChain3::SetColorSpace1() failure handling is wrong.

Chromium does like the following.
https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium

Current implementation is not wrong. chromium does nothing on the error. Somehow, I misread "SUCCEEDED" as "FAILED" :(
On Firefox, it might be better to disable video overlay with the SetColorSpace1() error.

Attachment #9284645 - Attachment description: Bug 1778622 - Fix IDXGISwapChain3::SetColorSpace1() error handling in DCSurfaceVideo::CallVideoProcessorBlt() → Bug 1778622 - Disable video overlay by IDXGISwapChain3::SetColorSpace1() error.

Calling NotifyWebRenderError(wr::WebRenderError::VIDEO_OVERLAY) disables video overly in GPUProcessManager::NotifyWebRenderError()

Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6aa6351f4d9
Disable video overlay by IDXGISwapChain3::SetColorSpace1() error. r=gfx-reviewers,lsalzman
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: