1778622 - Fix IDXGISwapChain3::SetColorSpace1() error handling in DCSurfaceVideo::CallVideoProcessorBlt()

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

IDXGISwapChain3::SetColorSpace1() failure handling is wrong.

Chromium does like the following.
https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1778622 - Disable video overlay by IDXGISwapChain3::SetColorSpace1() error.

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro away July/11 - July/19] from comment #0)

IDXGISwapChain3::SetColorSpace1() failure handling is wrong.

Chromium does like the following.
https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium

Current implementation is not wrong. chromium does nothing on the error. Somehow, I misread "SUCCEEDED" as "FAILED" :(
On Firefox, it might be better to disable video overlay with the SetColorSpace1() error.

Comment 3

[Sotaro Ikeda [:sotaro]]

Calling NotifyWebRenderError(wr::WebRenderError::VIDEO_OVERLAY) disables video overly in GPUProcessManager::NotifyWebRenderError()

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6aa6351f4d9
Disable video overlay by IDXGISwapChain3::SetColorSpace1() error. r=gfx-reviewers,lsalzman

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e6aa6351f4d9