Closed Bug 1778632 Opened 2 years ago Closed 2 years ago

Update dav1d to new version 79bc755d19d61644360bef4402fcce69f280ea52 from 2022-07-06 20:49:33

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: update-bot, Assigned: chunmin)

Details

(Whiteboard: [3pl-filed][task_id: Omap8HxUTxG1CKORqaNKsQ])

Attachments

(1 file)

This update covers 29 commits:


79bc755d19d61644360bef4402fcce69f280ea52 by Konstantin Pavlov

https://code.videolan.org/videolan/dav1dcommit/79bc755d19d61644360bef4402fcce69f280ea52
Authored: 2022-07-03 14:50:44 +0400
Committed: 2022-07-06 20:49:33 +0000

CI: Removed snap package generation

snapcraft version we use is no longer compatible with authentication
schemes snap store uses. This could be fixed by updating the snapcraft
inside the docker image, but Ubuntu no longer ships an up to date
snapcraft version in their own repositories. The other way to install
snapcraft is to manually fetch the project and core snaps just like we
do in https://code.videolan.org/videolan/docker-images/-/blob/master/vlc-ubuntu-focal/Dockerfile,
but that currently fails on Jammy due to conflict in Python versions
between what is shipped in Jammy and inside snapcraft project.

All in all, it seems snapcraft seems to be abandoned for our CI
use-case, and the usefulness of dav1d snap is disputable, so just drop
it altogether. Packaging is still available in package/snap/ for the
brave souls who want to build it on their own.

Files Modified:

  • .gitlab-ci.yml

bd0466350d20e2c6aab4c47668cd5486dc7a3d94 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/bd0466350d20e2c6aab4c47668cd5486dc7a3d94
Authored: 2022-07-06 14:43:44 +0200
Committed: 2022-07-06 15:05:47 +0200

Eliminate unused C DSP functions at compile time

When compiling with asm enabled there's no point in compiling
C versions of DSP functions that have asm implementations using
instruction sets that the compiler can unconditionally use.

E.g. when compiling with -mssse3 we can remove the C version
of all functions with SSSE3 implementations.

This is accomplished using the compiler's dead code elimination
functionality.

Can be configured using the new 'trim_dsp' meson option, which
by default is enabled when compiling in release mode.

Files Added:

  • src/ppc/cdef.h

Files Modified:

  • .gitlab-ci.yml
  • meson.build
  • meson_options.txt
  • src/cdef.h
  • src/cdef_tmpl.c
  • src/cpu.h
  • src/filmgrain.h
  • src/filmgrain_tmpl.c
  • src/ipred.h
  • src/ipred_tmpl.c
  • src/itx.h
  • src/itx_tmpl.c
  • src/loopfilter.h
  • src/loopfilter_tmpl.c
  • src/looprestoration.h
  • src/looprestoration_tmpl.c
  • src/mc.h
  • src/mc_tmpl.c
  • src/meson.build
  • src/msac.c
  • src/refmvs.c
  • src/x86/msac.h
  • tests/checkasm/checkasm.c

Files Changed:

  • R098 src/arm/cdef_init_tmpl.c
  • R085 src/arm/filmgrain_init_tmpl.c
  • R097 src/arm/ipred_init_tmpl.c
  • R097 src/arm/itx_init_tmpl.c
  • R095 src/arm/loopfilter_init_tmpl.c
  • R098 src/arm/looprestoration_init_tmpl.c
  • R098 src/arm/mc_init_tmpl.c
  • R095 src/arm/refmvs_init.c
  • R092 src/ppc/cdef_init_tmpl.c
  • R064 src/x86/msac_init.c
  • R094 src/ppc/looprestoration_init_tmpl.c
  • R097 src/x86/cdef_init_tmpl.c
  • R097 src/x86/filmgrain_init_tmpl.c
  • R098 src/x86/ipred_init_tmpl.c
  • R089 src/x86/itx_init_tmpl.c
  • R096 src/x86/loopfilter_init_tmpl.c
  • R093 src/x86/looprestoration_init_tmpl.c
  • R099 src/x86/mc_init_tmpl.c
  • R096 src/x86/refmvs_init.c

820bf5156322ea6f9d1fc180ac579743347b9c5b by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/820bf5156322ea6f9d1fc180ac579743347b9c5b
Authored: 2022-07-06 14:42:43 +0200
Committed: 2022-07-06 14:56:24 +0200

cpu: Inline dav1d_get_cpu_flags()

Files Modified:

  • include/common/attributes.h
  • src/cpu.c
  • src/cpu.h

233737c9b18e84372701e89bf57098257a30c8e4 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/233737c9b18e84372701e89bf57098257a30c8e4
Authored: 2022-06-22 16:56:40 +0200
Committed: 2022-06-22 17:01:45 +0200

x86: Add minor loopfilter asm improvements

Files Modified:

  • src/x86/loopfilter16_avx2.asm
  • src/x86/loopfilter_avx2.asm
  • src/x86/loopfilter_avx512.asm

0421f787ea592fd2cc74c887f20b8dc31393788b by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/0421f787ea592fd2cc74c887f20b8dc31393788b
Authored: 2022-06-15 16:55:55 +0200
Committed: 2022-06-20 21:11:13 +0000

checkasm: Speed up signal handling

Enabling/disabling signal handlers is very slow and requires a syscall.

A better approach is to keep the signal handlers enabled all the time,
and use a simple flag variable to determine if a given signal should
be handled or passed on to the default signal handler.

Files Modified:

  • tests/checkasm/checkasm.c

fa68b036b25f7a5a30833de924b7a27e149699eb by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/fa68b036b25f7a5a30833de924b7a27e149699eb
Authored: 2022-06-15 16:55:42 +0200
Committed: 2022-06-20 21:11:13 +0000

checkasm: Improve seed generation on Windows

GetTickCount() increases at a very low frequency, >10ms per tick.
When running multiple loops of checkasm instances in parallel
different instances regularly ends up using identical seeds.

Prefer the use of QueryPerformanceCounter() instead, which ticks at
a significantly higher rate, which in turn increases randomness.

Files Modified:

  • tests/checkasm/checkasm.c

0c590fc74d248541df3c0ad47683f642a36e465a by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/0c590fc74d248541df3c0ad47683f642a36e465a
Authored: 2022-06-20 14:43:33 +0200
Committed: 2022-06-20 15:44:22 +0200

ci: Don't specify a specific MacOS version

Files Modified:

  • .gitlab-ci.yml

b0907cf96b1756b50a321e6ed5b8b6910b35d701 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/b0907cf96b1756b50a321e6ed5b8b6910b35d701
Authored: 2022-06-14 22:34:45 +0200
Committed: 2022-06-15 01:27:40 +0200

x86: Add high bit-depth loopfilter AVX-512 (Ice Lake) asm

Files Added:

  • src/x86/loopfilter16_avx512.asm

Files Modified:

  • src/meson.build
  • src/x86/loopfilter_init_tmpl.c

9717802d01942e795d2749bef455a7ef0233f560 by Victorien Le Couviour--Tuffet

https://code.videolan.org/videolan/dav1dcommit/9717802d01942e795d2749bef455a7ef0233f560
Authored: 2022-06-13 14:00:59 +0200
Committed: 2022-06-13 14:00:59 +0200

checkasm/lpf: Use operating dimensions

Fixes use of uninitialized value.

Files Modified:

  • tests/checkasm/loopfilter.c

7576cd572f3ab5f6543a70dcc606e131110dbcd8 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/7576cd572f3ab5f6543a70dcc606e131110dbcd8
Authored: 2022-06-03 19:19:25 +0200
Committed: 2022-06-03 20:55:53 +0200

checkasm: Print the cpu model and cpuid signature on x86

Files Modified:

  • tests/checkasm/checkasm.c
  • tests/checkasm/x86/checkasm.asm

0aa04fd326a1109fc4cd24aba1874fe74f85a562 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/0aa04fd326a1109fc4cd24aba1874fe74f85a562
Authored: 2022-06-03 14:14:52 +0200
Committed: 2022-06-03 20:55:48 +0200

checkasm: Add a vzeroupper check on x86

Verifying that the YMM state is clean when returning from assembly
functions helps catching potential issues with AVX/SSE transitions.

Files Modified:

  • tests/checkasm/checkasm.c
  • tests/checkasm/x86/checkasm.asm

0cfb03cd6eddbaf350b17e06af6fa956e3455a00 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/0cfb03cd6eddbaf350b17e06af6fa956e3455a00
Authored: 2022-06-02 20:29:38 +0200
Committed: 2022-06-02 23:58:39 +0200

x86: Add a workaround for quirky AVX-512 hardware behavior

On Intel CPUs certain AVX-512 shuffle instructions incorrectly
flag the upper halves of YMM registers as in use when writing
to XMM registers, which may cause AVX/SSE state transitions.

This behavior is not documented and only occurs on physical
hardware, not when using the Intel SDE, so as far as I can tell
it appears to be a hardware bug.

Work around the issue by using EVEX-only registers. This avoids
the problem at the cost of a slightly larger code size.

Files Modified:

  • src/x86/ipred16_avx512.asm
  • src/x86/ipred_avx512.asm
  • src/x86/mc16_avx512.asm
  • src/x86/mc_avx512.asm

b4f9eac85803303760f90ebad49de068cc2663d7 by Victorien Le Couviour--Tuffet

https://code.videolan.org/videolan/dav1dcommit/b4f9eac85803303760f90ebad49de068cc2663d7
Authored: 2022-05-31 16:23:56 +0200
Committed: 2022-05-31 16:28:34 +0000

checkasm: Fix uninitialized variable

fg_data->num_y_points is used in generate_grain_uv, but is only set
after the call: move the initialization above.

Files Modified:

  • tests/checkasm/filmgrain.c

8c079f784a48e7241a1bb6cca0a063b7a654cd2b by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/8c079f784a48e7241a1bb6cca0a063b7a654cd2b
Authored: 2022-05-14 12:00:07 +0200
Committed: 2022-05-25 19:41:34 +0200

CI: Update coverage collecting

artifacts:reports:cobertura was deprecated in GitLab 14.9

Files Modified:

  • .gitlab-ci.yml

0770d98d9346075ee71af66541f651f756341a0c by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/0770d98d9346075ee71af66541f651f756341a0c
Authored: 2022-05-05 22:39:03 +0200
Committed: 2022-05-25 19:41:34 +0200

CI: Add a build with the minimum requirements

  • meson 0.49.0
  • nasm 2.14

Files Modified:

  • .gitlab-ci.yml

7d859f9c728e5042f9e1fbb98625d624c489a50e by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/7d859f9c728e5042f9e1fbb98625d624c489a50e
Authored: 2022-05-05 23:50:25 +0200
Committed: 2022-05-25 19:41:34 +0200

CI: Deactivate git 'safe.directory'

An attacker already has arbitrary code execution inside the container.

Ref: CVE-2022-24765

Files Modified:

  • .gitlab-ci.yml

c1264cd27e4a4e3b4ec95565ba23237539322839 by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/c1264cd27e4a4e3b4ec95565ba23237539322839
Authored: 2022-03-24 19:40:34 +0100
Committed: 2022-05-25 19:41:34 +0200

CI: Update images

Files Modified:

  • .gitlab-ci.yml

ebeaac6d60df0fdc8772f84d43a310eeed877185 by Victorien Le Couviour--Tuffet

https://code.videolan.org/videolan/dav1dcommit/ebeaac6d60df0fdc8772f84d43a310eeed877185
Authored: 2022-05-25 19:10:00 +0200
Committed: 2022-05-25 19:10:00 +0200

Fix typo

Insert missing space.

Files Modified:

  • tests/checkasm/mc.c

f920738fc1c2e0e959d3bdd2765c320a9e26143d by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/f920738fc1c2e0e959d3bdd2765c320a9e26143d
Authored: 2022-05-19 21:11:21 +0200
Committed: 2022-05-25 15:05:41 +0000

x86: Add high bit-depth cdef_filter AVX-512 (Ice Lake) asm

Files Added:

  • src/x86/cdef16_avx512.asm

Files Modified:

  • src/meson.build
  • src/x86/cdef_init_tmpl.c

a8d1a85a1b78308157e3b6c83c886280604d4f31 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/a8d1a85a1b78308157e3b6c83c886280604d4f31
Authored: 2022-05-20 14:51:45 +0200
Committed: 2022-05-20 14:51:45 +0200

checkasm: Print --help message to stderr instead of stdout

Files Modified:

  • tests/checkasm/checkasm.c

3d9e848cd23d2833e86961f7b282279d985b7df9 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/3d9e848cd23d2833e86961f7b282279d985b7df9
Authored: 2022-05-20 13:49:15 +0200
Committed: 2022-05-20 13:59:34 +0200

checkasm: Split cdef test into separate pri/sec/pri+sec parts

Makes it possible to benchmark the different code paths individually.

Files Modified:

  • tests/checkasm/cdef.c

297682250fd77b014d7b0fc63e61782025426a1a by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/297682250fd77b014d7b0fc63e61782025426a1a
Authored: 2022-05-20 02:28:33 +0200
Committed: 2022-05-20 13:59:33 +0200

checkasm: Improve benchmarking of functions that modify their input

Alternate between buffers when benchmarking in order to more
accurately measure throughout instead of latency.

Files Modified:

  • tests/checkasm/cdef.c
  • tests/checkasm/checkasm.h
  • tests/checkasm/itx.c
  • tests/checkasm/loopfilter.c
  • tests/checkasm/looprestoration.c
  • tests/checkasm/mc.c
  • tests/checkasm/msac.c

dd3b1eb88681e1ccac62e69840539c8c65f2105f by David Michael Barr

https://code.videolan.org/videolan/dav1dcommit/dd3b1eb88681e1ccac62e69840539c8c65f2105f
Authored: 2022-05-18 13:23:49 -0400
Committed: 2022-05-18 13:24:55 -0400

x86/itx_avx2: fix typo

Files Modified:

  • src/x86/itx_avx2.asm

9833c92807715d5b6ca0f88d13081e25744d65e0 by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/9833c92807715d5b6ca0f88d13081e25744d65e0
Authored: 2022-04-22 20:06:45 +0200
Committed: 2022-05-07 16:51:25 +0200

CI: Add gcc12 and clang14 builds with mold linker

Files Modified:

  • .gitlab-ci.yml

1bd91c3e6738cafeee3289a77e936ba1d823937c by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/1bd91c3e6738cafeee3289a77e936ba1d823937c
Authored: 2022-04-26 23:50:19 +0200
Committed: 2022-05-06 01:52:36 +0200

CI: Trigger documentation rebuild if configuration changes

Additionally, switch from 'only'/'except' to 'rules' which is
more flexible.

Files Modified:

  • .gitlab-ci.yml

9c69574d0f15e03e9376cbcf993996b4f8f3c040 by Matthias Dressel

https://code.videolan.org/videolan/dav1dcommit/9c69574d0f15e03e9376cbcf993996b4f8f3c040
Authored: 2022-04-24 01:09:47 +0200
Committed: 2022-05-06 01:52:36 +0200

meson/doc: Fix doxygen config

  • Doxygen had a longstanding bug [0] where it would use dot even if
    not configured to do so. Due to this behaviour our config magically
    worked.
    This bug is fixed in 1.9.2 therefore we need to explicitly enable
    dot support in order to keep existing functionality.

  • Enables WARN_AS_ERROR to catch mistakes.

  • Adds a version string to the header to easily identify which commit
    the docs are built from.

[0] https://github.com/doxygen/doxygen/issues/7273

Files Modified:

  • doc/meson.build

Files Changed:

  • R076 doc/Doxyfile.in

601bfe21b7ad4397a8d12a3803f454b062279bc1 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/601bfe21b7ad4397a8d12a3803f454b062279bc1
Authored: 2022-04-28 15:58:13 +0200
Committed: 2022-04-28 16:17:08 +0200

Use a relaxed memory ordering in dav1d_ref_inc()

Increasing a reference counter only requires atomicity, but not
ordering or synchronization.

Files Modified:

  • include/compat/gcc/stdatomic.h
  • include/compat/msvc/stdatomic.h
  • src/ref.h

6d0d066654d43d5eeffce958604c72d0c9cfbeed by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/6d0d066654d43d5eeffce958604c72d0c9cfbeed
Authored: 2022-04-28 13:24:56 +0200
Committed: 2022-04-28 13:24:56 +0200

Remove redundant code in dav1d_cdf_thread_unref()

Checking if the Dav1dRef pointer is non-zero and zeroing it is
already performed in dav1d_ref_dec(), no need to do it twice.

Also reorder code to enable tail call elimination.

Files Modified:

  • src/cdf.c

8bb0655895f9457ab5157f92adf311d9bd5e2801 by Henrik Gramner

https://code.videolan.org/videolan/dav1dcommit/8bb0655895f9457ab5157f92adf311d9bd5e2801
Authored: 2022-04-28 02:53:52 +0200
Committed: 2022-04-28 02:53:52 +0200

Inline dav1d_ref_inc()

Avoids the function call overhead in non-LTO builds.

Also reorder code in dav1d_ref_dec() to enable tail call elimination.

Files Modified:

  • src/ref.c
  • src/ref.h

./mach vendor media/libdav1d/moz.yaml reported an error editing moz.build files:

Latest commit is 79bc755d19d61644360bef4402fcce69f280ea52 from 2022-07-06T20:49:33.000+00:00
Fetching code archive from https://code.videolan.org/videolan/dav1d/-/archive/79bc755d19d61644360bef4402fcce69f280ea52.tar.gz
Retaining wanted in-tree files.
Cleaning third_party/dav1d to import changes.
Unpacking upstream files for third_party/dav1d.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: ['/tmp/tmp6schlg58/tools/output/null.c', '/tmp/tmp6schlg58/tools/output/md5.c', '/tmp/tmp6schlg58/doc/Doxyfile.in.in', '/tmp/tmp6schlg58/package/crossfiles/arm-android.meson', '/tmp/tmp6schlg58/tools/output/output.c', '/tmp/tmp6schlg58/tools/output/yuv.c', '/tmp/tmp6schlg58/tools/input/input.c', '/tmp/tmp6schlg58/tools/input/ivf.c', '/tmp/tmp6schlg58/doc/meson.build', '/tmp/tmp6schlg58/tools/dav1d.manifest', '/tmp/tmp6schlg58/examples/dp_fifo.c', '/tmp/tmp6schlg58/tools/compat/getopt.c', '/tmp/tmp6schlg58/examples/dp_fifo.h', '/tmp/tmp6schlg58/package/snap/snapcraft.yaml', '/tmp/tmp6schlg58/tools/input/section5.c', '/tmp/tmp6schlg58/tools/output/xxhash.c', '/tmp/tmp6schlg58/.gitlab-ci.yml', '/tmp/tmp6schlg58/tools/output/muxer.h', '/tmp/tmp6schlg58/examples/dp_renderer_placebo.c', '/tmp/tmp6schlg58/tools/output/output.h', '/tmp/tmp6schlg58/doc/dav1d_logo.svg', '/tmp/tmp6schlg58/tools/dav1d_cli_parse.c', '/tmp/tmp6schlg58/package/crossfiles/x86_64-w64-mingw32.meson', '/tmp/tmp6schlg58/examples/dp_renderer.h', '/tmp/tmp6schlg58/tools/dav1d.c', '/tmp/tmp6schlg58/tools/input/annexb.c', '/tmp/tmp6schlg58/package/crossfiles/i686-linux32.meson', '/tmp/tmp6schlg58/.gitignore', '/tmp/tmp6schlg58/tools/input/demuxer.h', '/tmp/tmp6schlg58/tools/output/y4m2.c', '/tmp/tmp6schlg58/tools/meson.build', '/tmp/tmp6schlg58/tools/dav1d.rc.in', '/tmp/tmp6schlg58/examples/meson.build', '/tmp/tmp6schlg58/tools/input/parse.h', '/tmp/tmp6schlg58/examples/dp_renderer_sdl.c', '/tmp/tmp6schlg58/doc/dav1d_logo.png', '/tmp/tmp6schlg58/package/crossfiles/aarch64-android.meson', '/tmp/tmp6schlg58/tools/input/input.h', '/tmp/tmp6schlg58/package/crossfiles/i686-w64-mingw32.meson', '/tmp/tmp6schlg58/doc/PATENTS', '/tmp/tmp6schlg58/examples/dav1dplay.c', '/tmp/tmp6schlg58/tools/dav1d_cli_parse.h']
Copying to third_party/dav1d.
Updating files
action: copy-file src: /builds/worker/checkouts/gecko/third_party/dav1d/include/vcs_version.h.in dst: /builds/worker/checkouts/gecko/media/libdav1d/vcs_version.h
action: replace-in-file file: /builds/worker/checkouts/gecko/media/libdav1d/vcs_version.h
action: run-script script: /builds/worker/checkouts/gecko/media/libdav1d/update-version.sh working dir: /builds/worker/checkouts/gecko/third_party/dav1d args: ['/builds/worker/checkouts/gecko/media/libdav1d/version.h']
/builds/worker/checkouts/gecko/media/libdav1d/update-version.sh /builds/worker/checkouts/gecko/media/libdav1d/version.h
Registering changes with version control.
Checking for a spurious update.
Version '79bc755d19d61644360bef4402fcce69f280ea52' has changed 87 files.
Updating moz.yaml.
Found release: ffb59680356fd210816cf9e46d9d023ade1f4d5a (2022-04-24T20:58:00.000+02:00).

Found revision: ffb59680356fd210816cf9e46d9d023ade1f4d5a

Updating moz.build files
Found 4 files added and 19 files removed.
Could not add third_party/dav1d/src/ppc/cdef_tmpl.c to the appropriate moz.build file
Could not add third_party/dav1d/src/ppc/looprestoration_tmpl.c to the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/cdef_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/filmgrain_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/ipred_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/itx_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/loopfilter_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/looprestoration_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/arm/mc_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/ppc/cdef_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/ppc/looprestoration_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/cdef_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/filmgrain_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/ipred_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/itx_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/loopfilter_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/looprestoration_init_tmpl.c from the appropriate moz.build file
Could not remove third_party/dav1d/src/x86/mc_init_tmpl.c from the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.

We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.

Updatebot encountered an error while trying to submit to try.
Updatebot will be unable to do anything more for this library version.

Flags: needinfo?(cchang)

Run ./mach vendor media/libdav1d/moz.yaml to get the latest dav1d
version and update the revision number in moz.yaml.

According to the changes in third_party/dav1d/src/meson.build, the
media/libdav1d/asm/moz.build is updated as follows:

  • Remove {arm,x86}/refmvs_init.c
  • Remove {arm,x86}/cdef_init_tmpl.c
  • Remove {arm,x86}/filmgrain_init_tmpl.c
  • Remove {arm,x86}/ipred_init_tmpl.c
  • Remove {arm,x86}/itx_init_tmpl.c
  • Remove {arm,x86}/loopfilter_init_tmpl.c
  • Remove {arm,x86}/looprestoration_init_tmpl.c
  • Remove {arm,x86}/mc_init_tmpl.c
  • Remove x86/msac_init.c
  • Add x86/cdef16_avx512.asm
  • Add x86/loopfilter16_avx512.asm
Assignee: nobody → cchang
Status: NEW → ASSIGNED
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba94856bb48e
Update dav1d to 6dc03eee53df62c1fb82a735f70a1b2b16d26bf0 r=mjf
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Flags: needinfo?(cchang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: