1778651 - Add gfxCriticalNote for negative ANativeWindow size

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Jamie Nicol [:jnicol]]

I have been able to reproduce bug 1772839 locally, and at least with my STR the failure appears to be caused by the Surface's BufferQueue having been abandoned. We can detect this situation ourselves because ANativeWindow_getWidth returns a negative value in this state.

In this bug we'll therefore we add a gfxCriticalNote when ANativeWindow_getWidth/Height return a negative value. This will help us determine whether the crashes we are seeing are indeed due to abandoned BufferQueues, or something else.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1778651 - Add gfxCriticalNote for negative ANativeWindow size r?#gfx-reviewers

One possible cause of the failures to create an EGLSurface we are
seeing in bug 1772839 is that the Surface's underlying BufferQueue has
already been abandoned. In such circumstances,
ANativeWindow_getWidth/Height will return a negative value. If this
occurs, ensure we annotate crash reports via gfxCriticalNote. This
will allow us to determine whether the crashes we are seeing are
indeed due to an abandoned BufferQueue, or some other reason.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39fecab5c852
Add gfxCriticalNote for negative ANativeWindow size r=gfx-reviewers,geckoview-reviewers,aosmond,owlish

Comment 3

[Jamie Nicol [:jnicol]]

Comment on attachment 9284660 [details]
Bug 1778651 - Add gfxCriticalNote for negative ANativeWindow size r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Will be slower to get useful information to help diagnose bug 1772839
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds a simple annotation to crash reports
• String changes made/needed:
• Is Android affected?: Yes

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/39fecab5c852

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9284660 [details]
Bug 1778651 - Add gfxCriticalNote for negative ANativeWindow size r?#gfx-reviewers

Approved for 103.0b7, thanks.

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/79206f917b07