Closed
Bug 1778706
Opened 2 years ago
Closed 2 years ago
Fix typo in postSigningData removal in uninstaller
Categories
(Firefox :: Installer, defect)
Firefox
Installer
Tracking
()
VERIFIED
FIXED
104 Branch
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
It should be removing postSigningData
, but it's actually trying to remove postSigningData.json
, per https://phabricator.services.mozilla.com/D144167#4946657
Assignee | ||
Comment 1•2 years ago
|
||
This file never has an extension.
Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/955eb5fba398 Fix typo in postSigningData removal in uninstaller r=bytesized
Assignee | ||
Comment 3•2 years ago
|
||
Comment on attachment 9284698 [details]
Bug 1778706: Fix typo in postSigningData removal in uninstaller r?bytesized!
Beta/Release Uplift Approval Request
- User impact if declined: Uninstalls will not always fully succeed.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1) Install Firefox
- Create a
postSigningData
file in the install directory (with no file extension) - Uninstall Firefox
Expected result: postSigningData
and the entire Firefox install directory should be removed
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): If the removal of this file fails the uninstaller will still work correctly.
- String changes made/needed:
- Is Android affected?: No
Attachment #9284698 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•2 years ago
|
Flags: qe-verify+
Comment 4•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Comment 5•2 years ago
|
||
Comment on attachment 9284698 [details]
Bug 1778706: Fix typo in postSigningData removal in uninstaller r?bytesized!
Approved for 103.0b7, thanks.
Attachment #9284698 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•2 years ago
|
||
bugherder uplift |
status-firefox103:
--- → fixed
Updated•2 years ago
|
QA Whiteboard: [qa-triaged]
Comment 7•2 years ago
|
||
Verified on Win10 using Beta 103.0b7 and Nightly 104.0a1 that steps from comment 3 work on .exe, .msi and stub installer and that uninstall works.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•