Closed Bug 1778706 Opened 2 years ago Closed 2 years ago

Fix typo in postSigningData removal in uninstaller

Categories

(Firefox :: Installer, defect)

defect

Tracking

()

VERIFIED FIXED
104 Branch
Tracking Status
firefox103 --- verified
firefox104 --- verified

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(1 file)

It should be removing postSigningData, but it's actually trying to remove postSigningData.json, per https://phabricator.services.mozilla.com/D144167#4946657

Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/955eb5fba398
Fix typo in postSigningData removal in uninstaller r=bytesized

Comment on attachment 9284698 [details]
Bug 1778706: Fix typo in postSigningData removal in uninstaller r?bytesized!

Beta/Release Uplift Approval Request

  • User impact if declined: Uninstalls will not always fully succeed.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1) Install Firefox
  1. Create a postSigningData file in the install directory (with no file extension)
  2. Uninstall Firefox

Expected result: postSigningData and the entire Firefox install directory should be removed

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): If the removal of this file fails the uninstaller will still work correctly.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9284698 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

Comment on attachment 9284698 [details]
Bug 1778706: Fix typo in postSigningData removal in uninstaller r?bytesized!

Approved for 103.0b7, thanks.

Attachment #9284698 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified on Win10 using Beta 103.0b7 and Nightly 104.0a1 that steps from comment 3 work on .exe, .msi and stub installer and that uninstall works.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: