1778714 - Downloading from internal PDF viewer produces the wrong download link if link is copied from library.

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Monica Chiorean]

Attachment: Screenplay.gif

Found in
Firefox 103.0b6

Affected versions
Firefox 103.0b6
Firefox 104.0a1

Affected platforms
Windows 10
macOS10.13
Ubuntu 20.04

Steps to reproduce

1. Open FF.
2. Open pdf file. (I used "http://www.pdf995.com/samples/pdf.pdf ").
3. Download pdf.
4. Open download file (Library).
5. Right click on the downloaded pdf 'Copy Download link'.
6. Paste the copied link to a new tab.

Expected result
Copied file should be “http://www.pdf995.com/samples/pdf.pdf”.

Actual result
Copied file is "blob:resource://pdf.js/9f79bca1-df79-4060-b207-24dd3f6d5374".

Regression range
Will add as soon as possible.

Additional notes

• The issue is related to bug 1766030.
• Issue is fixed if downloaded panel is reached from the toolbar button. Only reproducible if downloaded panel is reached from the Library view.

Comment 1

[Calixte Denizet (:calixte)]

Attachment: Bug 1778714 - Fix the pdf download link in the All Downloads view r=gijs

Comment 2

[Calixte Denizet (:calixte)]

:gijs, do you have any idea on how I can test that stuff ?

Comment 3

[:Gijs (he/him)]

(In reply to Calixte Denizet (:calixte) from comment #2)

:gijs, do you have any idea on how I can test that stuff ?

Unfortunately about:downloads is undertested. Try looking at https://searchfox.org/mozilla-central/source/browser/components/downloads/test/browser/browser_about_downloads.js and copying that test. In terms of the selection + copy-pasting, I'd suggest invoking cmd_copy via goDoCommand - https://searchfox.org/mozilla-central/search?q=cmd_copy&path=test&case=false&regexp=false has a few examples.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/724282da88eb
Fix the pdf download link in the All Downloads view r=Gijs

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_library_select_all.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1504dd3d9308e26b7cb54bb2a77d3382cf1078d3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=SVmi-a5CQ42lZuNqkPAwFg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=724282da88ebc224ce194e53d83bfef0ae074661

Failure log: https://treeherder.mozilla.org/logviewer?job_id=386667120&repo=autoland&lineNumber=5434

Comment 6

[Calixte Denizet (:calixte)]

My bad, it's a typo:
https://hg.mozilla.org/integration/autoland/rev/1504dd3d9308e26b7cb54bb2a77d3382cf1078d3#l1.12

downlad instead of download...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01b9d9c47f46
Fix the pdf download link in the All Downloads view r=Gijs

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/01b9d9c47f46

Comment 9

[Monica Chiorean]

Verified as fixed on Win10/Mac 10.13/Ubuntu20.4 using Beta 105.0b4.

Comment 10

[Calixte Denizet (:calixte)]

Comment on attachment 9284808 [details]
Bug 1778714 - Fix the pdf download link in the All Downloads view r=gijs

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Ergonomics fix for PDF downloads
• User impact if declined: User will get a blob url when they will copy the url from the All downloads view.
• Fix Landed on Version: 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small changes and it has an automated test.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9284808 [details]
Bug 1778714 - Fix the pdf download link in the All Downloads view r=gijs

Approved for 102.3esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/b87d48b3714d

Comment 13

[Monica Chiorean]

Verified issue as fixed on Win10, Ubuntu20.04, Mac10.13 using FF build 102.3.0esr( 20220912135840).