1778745 - [wpt-sync] Sync PR 34739 - [SPC] Update tests for input parameter validation

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34739 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34739
Details from upstream follow.

Stephen McGruer <[e-mail]> wrote:

[SPC] Update tests for input parameter validation

See https://github.com/w3c/secure-payment-confirmation/pull/195

The following tests are new:

• Empty ID within credentialIds field throws exception
• Multiple IDs in credentialIds is valid
• Empty instrument.displayName field throws exception
• Empty instrument.icon field throws exception
• Invalid instrument.icon URL throws exception
• Invalid rpId field throws exception
• Non-HTTPS payee origin throws exception

One timeout test was removed.

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e115bc48f7cef2388292690c20dc903648b00e

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 11 tests and 3 subtests

Status Summary

Firefox

OK : 11
FAIL: 40

Chrome

OK : 11
PASS: 38
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /secure-payment-confirmation/authentication-accepted.https.html [wpt.fyi]
  • Successful SPC authentication: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-cannot-bypass-spc.https.html [wpt.fyi]
  • Cannot bypass SPC authentication UI via navigator.credentials.get: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-cross-origin.sub.https.html [wpt.fyi]
  • Cross-origin SPC authentication ceremony: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-icon-data-url.https.html [wpt.fyi]
  • SPC authentication with data URL instrument icon: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-in-iframe.sub.https.html [wpt.fyi]
  • SPC authentication ceremony in cross-origin iframe: FAIL (Chrome: PASS)
  • SPC authentication ceremony in cross-origin iframe without payment permission: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-invalid-icon.https.html [wpt.fyi]
  • SPC authentication with an invalid icon: FAIL (Chrome: PASS)
  • SPC authentication allowing an invalid icon with iconMustBeShown option.: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-rejected.https.html [wpt.fyi]
  • Rejected SPC authentication: FAIL (Chrome: PASS)
• /secure-payment-confirmation/authentication-requires-user-activation.https.html [wpt.fyi]
  • SPC authentication not allowed without a user activation: FAIL (Chrome: PASS)
• /secure-payment-confirmation/constructor-validate-payment-method-data.https.html [wpt.fyi]
  • Empty credentialIds field throws exception.: FAIL (Chrome: PASS)
  • Empty ID within credentialIds field throws exception.: FAIL (Chrome: FAIL)
  • Multiple IDs in credentialIds is valid.: FAIL (Chrome: PASS)
  • Large credentialIds value throws exception.: FAIL (Chrome: PASS)
  • Null challenge field throws exception.: FAIL (Chrome: PASS)
  • Empty challenge field throws exception.: FAIL (Chrome: PASS)
  • Large challenge value throws exception.: FAIL (Chrome: PASS)
  • Empty instrument.displayName field throws exception.: FAIL (Chrome: PASS)
  • Empty instrument.icon field throws exception.: FAIL (Chrome: PASS)
  • Invalid instrument.icon URL throws exception.: FAIL (Chrome: PASS)
  • Invalid rpId field throws exception.: FAIL (Chrome: FAIL)
  • Omitting both payee origin and payee name throws exception.: FAIL (Chrome: PASS)
  • Payee name without payee origin is valid.: FAIL (Chrome: PASS)
  • Providing both payee name and payee origin is valid.: FAIL (Chrome: PASS)
  • Empty payee name throws exception.: FAIL (Chrome: PASS)
  • Empty payee origin throws exception.: FAIL (Chrome: PASS)
  • Non-HTTPS payee origin throws exception.: FAIL (Chrome: PASS)
• /secure-payment-confirmation/constructor.https.html [wpt.fyi]
  • Valid payment method data does not throw exceptions.: FAIL (Chrome: PASS)
  • The timeout field is optional.: FAIL (Chrome: PASS)
  • Extra payment method not allowed afterward.: FAIL (Chrome: PASS)
  • Extra payment method not allowed beforehand.: FAIL (Chrome: PASS)
  • The credentialIds field is required.: FAIL (Chrome: PASS)
  • The challenge field is required.: FAIL (Chrome: PASS)
  • Instrument field is required.: FAIL (Chrome: PASS)
  • Instrument display name is required.: FAIL (Chrome: PASS)
  • Instrument icon is required.: FAIL (Chrome: PASS)
  • rpId is required.: FAIL (Chrome: PASS)
• /secure-payment-confirmation/enrollment-in-iframe.sub.https.html [wpt.fyi]
  • SPC enrollment in cross-origin iframe: FAIL (Chrome: PASS)
  • SPC enrollment in cross-origin iframe fails without user activation: FAIL (Chrome: PASS)
  • SPC enrollment in cross-origin iframe without payment permission: FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bca5c64b5d0
[wpt PR 34739] - [SPC] Update tests for input parameter validation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c93600602dcf
[wpt PR 34739] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0bca5c64b5d0
https://hg.mozilla.org/mozilla-central/rev/c93600602dcf