Closed
Bug 1778855
Opened 2 years ago
Closed 2 years ago
gfxEnv::GlSpew() is not obviously MOZ_GL_SPEW
Categories
(Core :: Graphics, task)
Core
Graphics
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(2 files)
Generally, when reading code that uses gfxEnv vars, it's not obvious what ENV_VAR_SPELLING they pull from, thus isn't not clear what to set when trying to change them, from looking at the callsite alone.
Instead, we should create a strong and clear correlation by fetching MOZ_GL_SPEW=1 with gfxEnv::MOZ_GL_SPEW() -> true.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f8d3df1b73f Remove unused gfxEnv getters. r=gfx-reviewers,aosmond https://hg.mozilla.org/integration/autoland/rev/09c1aaff6c0e Use e.g. gfxEnv::MOZ_GL_DEBUG() instead of gfxEnv::GlDebug(). r=gfx-reviewers,jrmuizel
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1f8d3df1b73f
https://hg.mozilla.org/mozilla-central/rev/09c1aaff6c0e
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•