Remove useless ProcessPendingRestyles call.
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Regressed 1 open bug)
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•2 years ago
|
||
That was about XBL constructors being able to run script. But XBL is
gone and this should just be wasted work.
I want to land this in preparation for container queries substantially
changing the model here.
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef564358a7e8 Remove useless ProcessPendingRestyles call. r=boris
|
||
Comment 3•2 years ago
|
||
Backed out for causing wpt failures in CSSTransition-canceling.tentative.html
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | /css/css-transitions/CSSTransition-canceling.tentative.html | Setting display:none on an element cancels its transitions - assert_equals: expected "1000px" but got "0.0640197px"
|
|
Assignee | |
Comment 4•2 years ago
|
||
When something switches to display: none, right now we rely on
StopAnimationsForElementsWithoutFrames(), which posts a restyle and the
previous ProcessPendingRestyles call was papering over it.
For other elements in the display none subtree it doesn't matter,
because we don't keep their styles around, but for the display: none
element themselves we do need to update transitions on time.
We could, possibly more generally, remove
StopAnimationsForElementsWithoutFrames() altogether and cancel
animations when we clear style data, perhaps... But that's probably
worth a follow-up.
|
|
Assignee | |
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ea7d91368d1 Ensure we cancel transitions without the need of an extra flush. r=boris
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3176de5dffa Remove useless ProcessPendingRestyles call. r=boris
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3ea7d91368d1
https://hg.mozilla.org/mozilla-central/rev/d3176de5dffa
Description
•