Closed Bug 1779007 Opened 2 years ago Closed 2 years ago

tools/profiler/gecko/ProfilerParent.cpp:27:10: fatal error: platform.h: No such file or directory

Categories

(Core :: Gecko Profiler, defect, P3)

defect

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox102 --- unaffected
firefox103 --- unaffected
firefox104 --- fixed

People

(Reporter: petr.sumbera, Assigned: mozbugz)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

20:06.92 tools/profiler
20:07.97 In file included from Unified_cpp_tools_profiler0.cpp:56:
20:07.97 /builds/psumbera/mozilla-central-build/tools/profiler/gecko/ProfilerParent.cpp:27:10: fatal error: platform.h: No such file or directory
20:07.97    27 | #include "platform.h"
20:07.97       |          ^~~~~~~~~~~~
20:07.98 compilation terminated.

The first bad revision is:
changeset: 623110:c06c7a054281
user: Gerald Squelart <gsquelart@mozilla.com>
date: Wed Jul 06 03:01:46 2022 -0700
description:
Bug 1777890 - Re-enable the chunk manager logic to limit the global profile buffer memory usage - r=canaltinova

Fix for a regression in bug 1668867, which removed this important line.
Without it, the logic that handles chunk manager updates doesn't run, and the
overall buffer size limit across processes is not enforced anymore.

To catch future regressions, the ProfileBufferGlobalController now adds its
creation timestamp to the profiling log, which can be tested.

Differential Revision: https://phabricator.services.mozilla.com/D150995
Keywords: regression
Regressed by: 1777890

The Bugbug bot thinks this bug should belong to the 'Core::Gecko Profiler' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Gecko Profiler
Keywords: regression
Product: Firefox → Core

Set release status flags based on info from the regressing bug 1777890

:gerald, since you are the author of the regressor, bug 1777890, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(gsquelart)

On it.

Assignee: nobody → gsquelart
Severity: -- → N/A
Flags: needinfo?(gsquelart)
Priority: -- → P3
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b730f5946086
Fix non-MOZ_GECKO_PROFILER build - r=canaltinova

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: