Closed
Bug 1779010
Opened 2 years ago
Closed 2 years ago
Rely on WebGL zero initializing buffers in DrawTargetWebgl
Categories
(Core :: Graphics: Canvas2D, enhancement)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We use a zero'd pixel buffer object in DrawTargetWebgl for initializing textures. However, using calloc to do this causes the zero data to get serialized over IPC. This shows up heavily in profiles on startup. WebGL already zero initializes buffer data when a buffer is invalidated, so we can avoid having to use calloc and send the data over the wire.
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/579b9df20237 Rely on WebGL zero initializing buffers in DrawTargetWebgl. r=aosmond,gfx-reviewers
|
||
Comment 3•2 years ago
|
||
Backed out for causing assertion failures in Range.h
- Backout link
- Push with failures
- Failure Log
- Failure line: Assertion failure: !aLength (Range does not support nullptr with non-zero length.), at /builds/worker/workspace/obj-build/dist/include/mozilla/Range.h
Flags: needinfo?(lsalzman)
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/317c9080847f Rely on WebGL zero initializing buffers in DrawTargetWebgl. r=aosmond,gfx-reviewers
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•