Closed Bug 1779035 Opened 3 years ago Closed 3 years ago

Page shortcuts sometimes don't work when using non-qwerty keyboard layouts

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Firefox 102
defect

Tracking

()

VERIFIED INVALID

People

(Reporter: felix, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

There are some other related issues, but this one is very new (regression in Firefox v102).

When using a non-qwerty keyboard layout (i'm using bépo), web page shortcuts aren't triggered by the correct keys. Instead, I need to do like I was in qwerty to trigger them.

The issue is visible on Cinny (https://github.com/ajbura/cinny), Ctrl-K should open a in-page popup, but instead it opens the url bar.
It's also visible for Home Assistant (https://github.com/home-assistant/frontend), where "e", "c", "m" and ">" should open a pop-up. Instead, I need to use the location of those keys in qwerty to trigger the shortcut.

It was working properly before Firefox 102 (or maybe before 101).

The browser shortcuts (ctrl-shift-i, ctrl-s ctrl-t etc) work fine.

The issue is visible on Windows 10 AND Linux (gtk).

Qwerty is NOT configured anywhere on my system.

Expected results:

The shortcuts should be triggered by using the correct keyboard layout (bépo for me).

Also, shortcuts seem to work properly on some web pages. Youtube's "k" shortcut works fine.

The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Layout
Product: Firefox → Core
Component: Layout → DOM: UI Events & Focus Handling

It was working properly before Firefox 102 (or maybe before 101).

Qwerty is NOT configured anywhere on my system.

IIRC, nobody touches keyboard event dispatcher including native keyboard event handler in a couple of releases at least. Could you try to find the regression point with mozregression?

About Cinny, it refers KeyboardEvent.code which matches with physical key in QWERTY keyboard layout rather than active keyboard layout. So, Ctrl-S in BÉPO key label should work as Ctrl-K in the application. Is this what you expected?

About Home Assistant, I don't find their shortcut key handling.

Flags: needinfo?(felix)
Flags: needinfo?(felix)
Summary: Page shortcuts sometimes don't work when using non-qwerty (or azerty) keyboard layouts → Page shortcuts sometimes don't work when using non-qwerty keyboard layouts

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #3)

Erf… Indeed, it looks like both projects started using KeyboardEvent.code around the same time, thus triggering the bug I thought was related to Firefox.

Closing for now and opening issues on the projects.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID

I found the problematic pull request on Home Assistant. WTF, they caused the issue they were claiming to fix.

I found the problematic pull request on Home Assistant. WTF, they caused the issue they were claiming to fix.

https://github.com/home-assistant/frontend/pull/12892

Thank you for verifying the PR! That much helps to our bug report handling!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.