Closed Bug 1779116 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34743 - blink: Switch overflow overrides for replaced elements to used value.

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 34743 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34743
Details from upstream follow.

Khushal Sagar <khushalsagar@chromium.org> wrote:

blink: Switch overflow overrides for replaced elements to used value.

Replaced elements support only 2 configs for overflow: visible and clip.
Currently we apply this override at style resolution based on the
element tag to identify replaced elements. This misses cases where a
an element (like img) could be rendered as a non-replaced element if
fallback to alt text is used.

Avoid this by applying the override when using the value in
layout/paint when it's known whether the element will render as a replaced element.

See discussion at: https://github.com/w3c/csswg-drafts/issues/7435.

Bug: 1321217
Change-Id: Iadf653ea4a531a1ab313e2e797988d082d5ef1c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3750018
Auto-Submit: Khushal Sagar \<khushalsagar@chromium.org>
Reviewed-by: Chris Harrelson \<chrishtr@chromium.org>
Commit-Queue: Khushal Sagar \<khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1022859}

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6246a2c5ec26
[wpt PR 34743] - blink: Switch overflow overrides for replaced elements to used value., a=testonly

https://hg.mozilla.org/mozilla-central/rev/6246a2c5ec26

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.