[wpt-sync] Sync PR 34768 - [text-decorations] Use range in fuzzy for `text-decoration-subelements-002.html`
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox104 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 34768 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/34768
Details from upstream follow.
Koji Ishii <kojii@chromium.org> wrote:
[text-decorations] Use range in fuzzy for
text-decoration-subelements-002.html
After the fix crrev.com/c/3748547, the test in the wpt[1]
fails in Firefox too. Re-reading the spec[2], "max" means the
maximum value in the pixels of a PNG, not the maximum value
it can take. When it may vary, the values must be in the range
syntax.This patch allows 0 for both
maxDifference
andtotalPixels
so that exact match is also allowed.[1] https://wpt.fyi/results/css/css-text-decor/text-decoration-subelements-002.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=text-decor
[2] https://web-platform-tests.org/writing-tests/reftests.html#fuzzy-matchingBug: 1008951
Change-Id: I5650aadb11d2150599f5d829c5fa3938ffa5192d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3754787
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1022953}
Assignee | ||
Comment 1•2 years ago
|
||
PR 34768 applied with additional changes from upstream: d3422cc02be67fe0eaf5fe9df4c105a592d0d71c
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=249643fffa5c420dedcd7cf77fc2fe1c92d6b227
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/469ba0b52816 [wpt PR 34768] - [text-decorations] Use range in fuzzy for `text-decoration-subelements-002.html`, a=testonly https://hg.mozilla.org/integration/autoland/rev/af97ef1648e6 [wpt PR 34768] - Update wpt metadata, a=testonly
Assignee | ||
Comment 4•2 years ago
|
||
Test result changes from PR not available.
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/469ba0b52816
https://hg.mozilla.org/mozilla-central/rev/af97ef1648e6
Description
•