Performance optimisation in CachedTableCellAccessible::RowHeaderCells
Categories
(Core :: Disability Access APIs, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
Details
Attachments
(1 file)
RowHeaderCells currently calls CellAt, which returns an Accessible. But RowHeaderCells wants the CachedTableCellAccessible as well, so it then has to call AsTableCellBase, which walks the ancestors to get the table again. We already have the table and we have access to its private data, so we should just get what we need directly, avoiding unnecessary ancestor walks.
|
Assignee | |
Comment 1•2 years ago
|
||
Previously, we used CellAt, but this returns the Accessible, discarding the CachedTableCellAccessible.
RowHeaderCells needs both, so it then called AsTableCellBase, which must walk ancestors to get the table.
We already have the table and access to its private data, so use it directly.
This is probably an insignificant performance improvement, but the unnecessary indirection was bothering me.
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/432b229a7cb3 Don't walk ancestors unnecessarily in CachedTableCellAccessible::RowHeaderCells. r=morgan
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•