1779164 - Allow searching in a given Network response

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement)

Description

[Nicolas Chevobbe [:nchevobbe]]

CodeMirror already has a built-in search UI, but the Netmonitor SearchBox is stealing the focus, which makes the build-in search input quicky disappear (because of the blur event)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1779164 - [devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac6b6390147e
[devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy.

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on browser_net_filter-value-preserved.js
Backout link
Push with failures
Link to failure log
Failure line:
TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_filter-value-preserved.js | Value should be preserved after switching to right host - Got "", expected "hello"

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Looks like my patch causes the search input to be re-rendered. I'll update a new version with a fix soon

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/445cd004a422
[devtools] Don't override CodeMirror search UI in netmonitor response panel. r=bomsy.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/445cd004a422