17792 - text set via DOM displays in HTL password control

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[buster]

needs a little test case
I believe the situation is the document loads, then some javascript runs that
sets the value of the password control, and that text displays instead of '*'
replacement characters.

Comment 1

[buster]

setting to M12

Comment 2

[andreww]

Load this code into a xul file and click the button:
----------
<?xml version="1.0"?>

 <window xmlns:html="http://www.w3.org/TR/REC-html40"

xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

                <html:form >

                                <html:input id="pw" type="PASSWORD" name="pww"
                                        onkeyup="cmdPasswordKeyup();" />
                                <html:input id="foo" type="button" name='clickme'
onclick="document.getElementById('pw').value='see me'" />
                </html:form>


</window>
---------

What happens is that when you set the password form via the dom the text shows
up. The field must not have focus for you to see this. As soon as you give that
form field focus (clicking on it) the asterisks show up.

Comment 3

[buster]

fixed.
It's a very simple change.
The text control optimization was turned on for single line text controls,
and turned off for text areas.  With this change, the optimization is also
turned off for password fields.  This shouldn't effect performance in any
noticable way, because there are very rarely more than one or two password
controls on a single page.  The optimization in the case of password fields
isn't worth the extra code and complexity for dealing with replacing
characters with '*'
Not marked dogfood, but I really want to get all bugs related to my optimization
work off my plate for M11, so I can just get on with other work.

Comment 4

[cpratt]

Reassigning to ckritzer (I don't know DOM). ckritzer, if this is bad, please let
me know... thanks!

Comment 5

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- Linux6 2000-02-01-10 Commercial build
- Win98 2000-02-01-08 Commercial build
- MacOS86 2000-02-01-09 Commercial build