Closed Bug 1779203 Opened 2 years ago Closed 11 months ago

The panel remains opened when the user shrinks the PiP

Categories

(Toolkit :: Picture-in-Picture, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr91 --- disabled
firefox102 --- disabled
firefox103 --- disabled
firefox104 --- disabled
firefox113 --- verified

People

(Reporter: danibodea, Assigned: niklas)

References

Details

(Whiteboard: [fidefe-MR1-2022])

Attachments

(1 file)

Note

  • When the user opens the PiP's subtitle settings panel and then shrinks the PiP, he will notice that the panel remains opened and spills out.

** Found in**

  • Beta v103.0b7

Affected versions

  • Nightly v104.0a1
  • Beta v103.0b7

Affected platforms

  • all

Steps to reproduce

  1. Load a youtube video with subtitles.
  2. Launch the PiP.
  3. Open the PiP's subtitle settings panel.
  4. Shrink the PiP, even under the size where the subtitle settings button disappers.

Expected result

  • The panel closes before it spills out.

Actual result

  • The panel remains displayed and spills out on the PiP.

Regression range

  • This is NOT a regression but is a lot easier to reproduce after the latest bug fixes (panel remains displayed if the user hovers outside of the PiP).

Additional notes
*

Has STR: --- → yes
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d98f398d1969
Hide subtitles panel on resize. r=pip-reviewers,kpatenio
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Flags: qe-verify+

I have verified this fix in Windows 10, 7, Ubuntu 22 and MacOS 11. In builds after the fix, the panel closes automatically when the user resizes the PiP.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.