1779219 - Add onboarding link to QuickActions

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Dale Harvey (:daleharvey)]

As per spec @ https://www.figma.com/file/o7FiykrKIyDBgsjEQUYDOr/Quick-actions-in-the-Awesomebar?node-id=7%3A2288

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1779219 - Add onboarding link to QuickActions. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8043340f122d
Add onboarding link to QuickActions. r=adw

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_quickactions.js

• backout: https://hg.mozilla.org/integration/autoland/rev/892a6b9a721203f925f7b607cec0dbd91b23ce7f
• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=MObmDvxcT72JdFHs-MCcxA.0&revision=8043340f122da406e6b7d29411592ec627923222&group_state=expanded
• failure log: https://treeherder.mozilla.org/logviewer?job_id=387548358&repo=autoland&lineNumber=3447

[task 2022-08-16T21:11:49.460Z] 21:11:49     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quickactions.js | The action is displayed - 2 == 2 - 
[task 2022-08-16T21:11:49.461Z] 21:11:49     INFO - Buffered messages finished
[task 2022-08-16T21:11:49.463Z] 21:11:49     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_quickactions.js | No results should be selected. - 1 == -1 - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_quickactions.js :: test_disabled :: line 127
[task 2022-08-16T21:11:49.463Z] 21:11:49     INFO - Stack trace:
[task 2022-08-16T21:11:49.463Z] 21:11:49     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_quickactions.js:test_disabled:127
[task 2022-08-16T21:11:49.465Z] 21:11:49     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quickactions.js | onPick for disabled action was not called - 0 == 0 - 

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/629fc32c6f5e
Add onboarding link to QuickActions. r=adw

Comment 6

[Marian-Vasile Laza]

Backed out changeset 629fc32c6f5e (Bug 1779219) for causing xpcshell failures on test_quickactions.js.
Backout link
Push with failures <--> X2
Failure Log

Comment 7

[Dale Harvey (:daleharvey)]

Argh apologies, keep making the mistake of assuming the simple patch wont break other tests, fixed and running via try

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20bf9adccfda
Add onboarding link to QuickActions. r=adw

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/20bf9adccfda

Comment 10

[Adrian Florinescu [:aflorinescu]]

Dale, the help page currently directs to: https://support.mozilla.org/en-US/kb/quick-actions-firefox-search-bar?as=u&utm_source=inproduct which is not found. Are/should we tracking this somewhere different?

Comment 11

[Dale Harvey (:daleharvey)]

Product and content are responsible for this and tracking seperately, it can be updated at any time so we dont need to track for release or anything, I have heard some work on it being done recently so should not be too long

Comment 12

[Dale Harvey (:daleharvey)]

Attachment: Bug 1779219 - Follow up to ensure onboarding button is correctly positioned. r=daisuke

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 14

[Dale Harvey (:daleharvey)]

This would usually be fine as a follow up but since we might need uplift on the follow up going to split it into a new bug

Comment 15

[Phabricator Automation]

Comment on attachment 9290969 [details]
Bug 1779219 - Follow up to ensure onboarding button is correctly positioned. r=daisuke

Revision D155259 was moved to bug 1786504. Setting attachment 9290969 [details] to obsolete.

Comment 16

[Alice Wyman]

(In reply to Adrian Florinescu [:aflorinescu] from comment #10)

Dale, the help page currently directs to: https://support.mozilla.org/en-US/kb/quick-actions-firefox-search-bar?as=u&utm_source=inproduct which is not found. Are/should we tracking this somewhere different?

For the record, this is bug 1786702.