1779269 - Can't copy from a textarea with disabled attribute on deepl.com, mobile only

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P3)

Description

[Ksenia Berezina [:ksenia]]

This was originally reported in https://github.com/webcompat/web-bugs/issues/101491.

1. To reproduce, visit https://www.deepl.com/translator#en/ro/bug in Firefox on mobile and long tap on the translation result (bug in Romanian) to attempt to copy text.

Expected:
Context menu is shown with an option to copy text.

Actual:
No context menu is displayed, therefore it's impossible to copy text through this interaction.

(the site is offering a "copy" button below the field, so it's possible to work around the issue)

Comment 1

[Ksenia Berezina [:ksenia]]

Attachment: 101491.html

I've attached a reduced test case. The issue is only reproducible on mobile.

Comment 2

[Ksenia Berezina [:ksenia]]

It's looks the same as bug 253870, which is resolved, and it's possible to copy on desktop, but looks like it's still an issue on mobile?

Comment 3

[Makoto Kato [:m_kato]]

GV shows action menu by accessiblecaret event. I guess that this may accessiblecaret issues since longtap doesn't show its caret even if Surface Pro. Chrome/Android shows accessiblecaret on this situation.

Comment 4

[Makoto Kato [:m_kato]]

TYLin, do you know why accessible caret isn't shown by comment #1 sample? It seems to be different behavior with Chrome/Android.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I can reproduce this on desktop with layout.accessiblecaret.enabled=true and layout.accessiblecaret.hide_carets_for_mouse_input=false. The AccesibleCaret doesn't show on the disabled <textarea> when selecting a text with mouse. Debugging ...

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1779269 - Fix AccessibleCaret's display on disabled form controls. r?emilio

A disabled form controls cannot be focused, and its frame selection is different
from the one for not-editable content. Use GetLastFocusedFrameSelection() (added
in Bug 253870) to get the correct frame selection that is visible to the user.

Add some basic tests for disabled <textarea> such as long pressing to select,
dragging, etc. They should behave the same as normal <textarea>.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429187de34ff
Fix AccessibleCaret's display on disabled form controls. r=emilio,webdriver-reviewers,whimboo

Comment 8

[Cristian Tuns]

Backed out for causing geckoview-junit failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.SelectionActionDelegateTest#compareClientRect[#input] | java.lang.AssertionError: Selection rect is not at expected location. aRectF(8.0, 8.0, 8.0, 30.0) bRectF(28.0, 49.75, 28.0, 71.75)

Comment 9

[Dennis Schubert [:denschub]]

WebCompat P2, but we should also reach out to ask them why they're using disabled instead of readonly.

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Fixed the geckoview-junit failures in the latest revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f4c6d247cd1
Fix AccessibleCaret's display on disabled form controls. r=emilio,webdriver-reviewers,whimboo,geckoview-reviewers,m_kato

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5f4c6d247cd1