1779422 - Make push state updates configurable in aboutWelcome

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

Allow users to configure whether aboutWelcome should make updates to window.history.pushState (see here). This will allow us to configure messages for the feature callout feature without overriding the parent page's pushState.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1779422 - Make push state updates configurable in aboutWelcome

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a66d46b4b28
Make push state updates configurable in aboutWelcome r=pdahiya

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing fxms failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/beb6bdecba52494b58a289c0ee616b904d8bcc10
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=1a66d46b4b288a14417a5f7f9fb69583ba928d30&selectedTaskRun=Jg9yJDbzTdyyaXYXFbbRqg.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=385141511&repo=autoland&lineNumber=3475

[task 2022-07-22T15:34:43.061Z]     "localizedText": {
[task 2022-07-22T15:34:43.061Z]       "type": "object",
[task 2022-07-22T15:34:43.061Z]       "properties": {
[task 2022-07-22T15:34:43.061Z]         "string_id": {
[task 2022-07-22T15:34:43.061Z]           "description": "Id of localized string to be rendered.",
[task 2022-07-22T15:34:43.061Z]           "type": "string"
[task 2022-07-22T15:34:43.061Z]         }
[task 2022-07-22T15:34:43.061Z]       },
[task 2022-07-22T15:34:43.061Z]       "required": [
[task 2022-07-22T15:34:43.061Z]         "string_id"
[task 2022-07-22T15:34:43.061Z]       ]
[task 2022-07-22T15:34:43.061Z]     },
[task 2022-07-22T15:34:43.061Z]     "localizableText": {
[task 2022-07-22T15:34:43.061Z]       "description": "Either a raw string or an object containing the string_id of the localized text",
[task 2022-07-22T15:34:43.061Z]       "oneOf": [
[task 2022-07-22T15:34:43.061Z]         {
[task 2022-07-22T15:34:43.061Z]           "type": "string",
[task 2022-07-22T15:34:43.061Z]           "description": "The string to be rendered."
[task 2022-07-22T15:34:43.061Z]         },
[task 2022-07-22T15:34:43.061Z]         {
[task 2022-07-22T15:34:43.061Z]           "$ref": "resource://activity-stream/schemas/MessagingExperiment.schema.json#/$defs/localizedText"
[task 2022-07-22T15:34:43.061Z]         }
[task 2022-07-22T15:34:43.061Z]       ]
[task 2022-07-22T15:34:43.061Z]     }
[task 2022-07-22T15:34:43.061Z]   }
[task 2022-07-22T15:34:43.062Z] }Traceback (most recent call last):
[task 2022-07-22T15:34:43.062Z]   File "make-schemas.py", line 456, in <module>
[task 2022-07-22T15:34:43.062Z]     main(args.check)
[task 2022-07-22T15:34:43.062Z]   File "make-schemas.py", line 437, in main
[task 2022-07-22T15:34:43.062Z]     check_diff(schema_def, schema)
[task 2022-07-22T15:34:43.062Z]   File "make-schemas.py", line 389, in check_diff
[task 2022-07-22T15:34:43.062Z]     raise ValueError("Schemas do not match!")
[task 2022-07-22T15:34:43.062Z] ValueError: Schemas do not match!
[task 2022-07-22T15:34:43.063Z] Creating default state directory: /builds/worker/.mozbuild
[taskcluster 2022-07-22 15:34:44.156Z] === Task Finished ===
[taskcluster 2022-07-22 15:34:44.156Z] Unsuccessful task run with exit code: 1 completed in 120.563 seconds

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc6fc0878feb
Make push state updates configurable in aboutWelcome r=pdahiya

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bc6fc0878feb

Comment 6

[Meg Viar [:mviar]]

Patch was updated and re-pushed on 7/22/22.