Closed Bug 1779422 Opened 3 months ago Closed 2 months ago

Make push state updates configurable in aboutWelcome

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Iteration:
104.2 - July 11 - July 22
Tracking Status
firefox104 --- fixed

People

(Reporter: mviar, Assigned: mviar)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Allow users to configure whether aboutWelcome should make updates to window.history.pushState (see here). This will allow us to configure messages for the feature callout feature without overriding the parent page's pushState.

Assignee: nobody → mviar
Priority: -- → P1
Iteration: --- → 104.2 - July 11 - July 22
Attachment #9285878 - Attachment description: WIP: Bug 1779422 - Make push state updates configurable in aboutWelcome → Bug 1779422 - Make push state updates configurable in aboutWelcome
Pushed by mviar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a66d46b4b28
Make push state updates configurable in aboutWelcome r=pdahiya

Backed out for causing fxms failures.

[task 2022-07-22T15:34:43.061Z]     "localizedText": {
[task 2022-07-22T15:34:43.061Z]       "type": "object",
[task 2022-07-22T15:34:43.061Z]       "properties": {
[task 2022-07-22T15:34:43.061Z]         "string_id": {
[task 2022-07-22T15:34:43.061Z]           "description": "Id of localized string to be rendered.",
[task 2022-07-22T15:34:43.061Z]           "type": "string"
[task 2022-07-22T15:34:43.061Z]         }
[task 2022-07-22T15:34:43.061Z]       },
[task 2022-07-22T15:34:43.061Z]       "required": [
[task 2022-07-22T15:34:43.061Z]         "string_id"
[task 2022-07-22T15:34:43.061Z]       ]
[task 2022-07-22T15:34:43.061Z]     },
[task 2022-07-22T15:34:43.061Z]     "localizableText": {
[task 2022-07-22T15:34:43.061Z]       "description": "Either a raw string or an object containing the string_id of the localized text",
[task 2022-07-22T15:34:43.061Z]       "oneOf": [
[task 2022-07-22T15:34:43.061Z]         {
[task 2022-07-22T15:34:43.061Z]           "type": "string",
[task 2022-07-22T15:34:43.061Z]           "description": "The string to be rendered."
[task 2022-07-22T15:34:43.061Z]         },
[task 2022-07-22T15:34:43.061Z]         {
[task 2022-07-22T15:34:43.061Z]           "$ref": "resource://activity-stream/schemas/MessagingExperiment.schema.json#/$defs/localizedText"
[task 2022-07-22T15:34:43.061Z]         }
[task 2022-07-22T15:34:43.061Z]       ]
[task 2022-07-22T15:34:43.061Z]     }
[task 2022-07-22T15:34:43.061Z]   }
[task 2022-07-22T15:34:43.062Z] }Traceback (most recent call last):
[task 2022-07-22T15:34:43.062Z]   File "make-schemas.py", line 456, in <module>
[task 2022-07-22T15:34:43.062Z]     main(args.check)
[task 2022-07-22T15:34:43.062Z]   File "make-schemas.py", line 437, in main
[task 2022-07-22T15:34:43.062Z]     check_diff(schema_def, schema)
[task 2022-07-22T15:34:43.062Z]   File "make-schemas.py", line 389, in check_diff
[task 2022-07-22T15:34:43.062Z]     raise ValueError("Schemas do not match!")
[task 2022-07-22T15:34:43.062Z] ValueError: Schemas do not match!
[task 2022-07-22T15:34:43.063Z] Creating default state directory: /builds/worker/.mozbuild
[taskcluster 2022-07-22 15:34:44.156Z] === Task Finished ===
[taskcluster 2022-07-22 15:34:44.156Z] Unsuccessful task run with exit code: 1 completed in 120.563 seconds
Flags: needinfo?(mviar)
Pushed by mviar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc6fc0878feb
Make push state updates configurable in aboutWelcome r=pdahiya
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

Patch was updated and re-pushed on 7/22/22.

Flags: needinfo?(mviar)
You need to log in before you can comment on or make changes to this bug.