1779445 - Deleted Icon no longer shows up in Subject in message list

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect, P5)

Description

[Bob Rahe]

Steps to reproduce:

Setting to "just mark as deleted" and delete a message.

Actual results:

Message line gets cross out but no deleted icon shows up in Subject column

Expected results:

Should be a deleted icon at the beginning of the Subject.

Comment 1

[Magnus Melin [:mkmelin]]

I can confirm. Not sure that icon really served a purpose.

Comment 2

[Magnus Melin [:mkmelin]]

Richard, do you remember if this was on purpose?

Comment 3

[Richard Marti (:Paenglab)]

This was changed in bug 1768505 (https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#262) but there is no defined icon set.

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

Comment 4

[Bob Rahe]

(In reply to Richard Marti (:Paenglab) from comment #3)

This was changed in bug 1768505 (https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#262) but there is no defined icon set.

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

I'd say the line-through would be sufficient if it was more visible. On my MacBook Pro with default theme it really doesn't show up very well at all. If there was a way to make it more visible that would work.

Comment 5

[Alessandro Castellani [:aleca]]

(In reply to Bob Rahe from comment #4)

I'd say the line-through would be sufficient if it was more visible. On my MacBook Pro with default theme it really doesn't show up very well at all. If there was a way to make it more visible that would work.

Thanks for the report.
Would you be able to share a screenshot?

(In reply to Richard Marti (:Paenglab) from comment #3)

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Indeed, on my end the line through seems enough of a visual queue without needing to add an extra icon. Maybe we could add an extra opacity: 0.8 to the whole row to better distinguish deleted messages from others without affecting contrast readability, only when not in High Contrast mode.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

Uh, I completely missed that. Indeed, we should fix this, good catch!

Comment 6

[Bob Rahe]

Attachment: Strike thru visibility issues: Screen Shot 2022-08-10 at 12.02.59 PM.png

Comment 7

[Bob Rahe]

(In reply to Alessandro Castellani [:aleca] from comment #5)

(In reply to Bob Rahe from comment #4)

I'd say the line-through would be sufficient if it was more visible. On my MacBook Pro with default theme it really doesn't show up very well at all. If there was a way to make it more visible that would work.

Thanks for the report.
Would you be able to share a screenshot?

(In reply to Richard Marti (:Paenglab) from comment #3)

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Indeed, on my end the line through seems enough of a visual queue without needing to add an extra icon. Maybe we could add an extra opacity: 0.8 to the whole row to better distinguish deleted messages from others without affecting contrast readability, only when not in High Contrast mode.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

Uh, I completely missed that. Indeed, we should fix this, good catch!

Just added one as an attachment to this bug id. If that's the way to do it. It shows both a highlighted an unhighlighted line with strike-throughs. Not real visible in either.....

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4fcc6bf6b5a6
Make imapdeleted message use a reduced opacity. r=aleca

Comment 10

[Richard Marti (:Paenglab)]

Comment on attachment 9289309 [details]
Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

[Approval Request Comment]
User impact if declined: missing restore icon
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9289309 [details]
Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 104.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/2969fd1c91f0

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9289309 [details]
Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

[Triage Comment]
Approved for esr102

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.2.0:
https://hg.mozilla.org/releases/comm-esr102/rev/cbca8b72fa27