Closed Bug 1779445 Opened 5 months ago Closed 4 months ago

Deleted Icon no longer shows up in Subject in message list

Categories

(Thunderbird :: Theme, defect, P5)

Thunderbird 102

Tracking

(thunderbird_esr102? fixed, thunderbird104? fixed)

RESOLVED FIXED
105 Branch
Tracking Status
thunderbird_esr102 ? fixed
thunderbird104 ? fixed

People

(Reporter: bob, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Steps to reproduce:

Setting to "just mark as deleted" and delete a message.

Actual results:

Message line gets cross out but no deleted icon shows up in Subject column

Expected results:

Should be a deleted icon at the beginning of the Subject.

Blocks: tb102found

I can confirm. Not sure that icon really served a purpose.

Severity: -- → S4
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5

Richard, do you remember if this was on purpose?

Component: Folder and Message Lists → Theme

This was changed in bug 1768505 (https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#262) but there is no defined icon set.

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

Flags: needinfo?(alessandro)

(In reply to Richard Marti (:Paenglab) from comment #3)

This was changed in bug 1768505 (https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#262) but there is no defined icon set.

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

I'd say the line-through would be sufficient if it was more visible. On my MacBook Pro with default theme it really doesn't show up very well at all. If there was a way to make it more visible that would work.

(In reply to Bob Rahe from comment #4)

I'd say the line-through would be sufficient if it was more visible. On my MacBook Pro with default theme it really doesn't show up very well at all. If there was a way to make it more visible that would work.

Thanks for the report.
Would you be able to share a screenshot?

(In reply to Richard Marti (:Paenglab) from comment #3)

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Indeed, on my end the line through seems enough of a visual queue without needing to add an extra icon. Maybe we could add an extra opacity: 0.8 to the whole row to better distinguish deleted messages from others without affecting contrast readability, only when not in High Contrast mode.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

Uh, I completely missed that. Indeed, we should fix this, good catch!

Flags: needinfo?(alessandro)

(In reply to Alessandro Castellani [:aleca] from comment #5)

(In reply to Bob Rahe from comment #4)

I'd say the line-through would be sufficient if it was more visible. On my MacBook Pro with default theme it really doesn't show up very well at all. If there was a way to make it more visible that would work.

Thanks for the report.
Would you be able to share a screenshot?

(In reply to Richard Marti (:Paenglab) from comment #3)

Alex, what do you think, should we re-add an icon or is the line-through enough? I think it's not needed.

Indeed, on my end the line through seems enough of a visual queue without needing to add an extra icon. Maybe we could add an extra opacity: 0.8 to the whole row to better distinguish deleted messages from others without affecting contrast readability, only when not in High Contrast mode.

Also https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/themes/shared/mail/messageIcons.css#58 doesn't exist and needs to be fixed.

Uh, I completely missed that. Indeed, we should fix this, good catch!

Just added one as an attachment to this bug id. If that's the way to do it. It shows both a highlighted an unhighlighted line with strike-throughs. Not real visible in either.....

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Target Milestone: --- → 105 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4fcc6bf6b5a6
Make imapdeleted message use a reduced opacity. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED

Comment on attachment 9289309 [details]
Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

[Approval Request Comment]
User impact if declined: missing restore icon
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9289309 - Flags: approval-comm-esr102?
Attachment #9289309 - Flags: approval-comm-beta?

Comment on attachment 9289309 [details]
Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

[Triage Comment]
Approved for beta

Attachment #9289309 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9289309 [details]
Bug 1779445 - Make imapdeleted message use a reduced opacity. r=aleca

[Triage Comment]
Approved for esr102

Attachment #9289309 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.