1779457 - Extend bug 1764354 to apply to content as well.

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Emilio Cobos Álvarez (:emilio)]

As per https://github.com/w3c/csswg-drafts/issues/7213

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1779457 - Make prefers-color-scheme of SVG images match embedder on content too. r=#layout,aosmond

As per discussion in https://github.com/w3c/csswg-drafts/issues/7213.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33fbecca098c
Make prefers-color-scheme of SVG images match embedder on content too. r=aosmond

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34845 for changes under testing/web-platform/tests

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f31efc2a9229
Fix test_mq_dynamic_svg.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34f9bcdd17ff
Annotate some tests as failing when using drawSnapshot while I investigate.

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/33fbecca098c
https://hg.mozilla.org/mozilla-central/rev/f31efc2a9229
https://hg.mozilla.org/mozilla-central/rev/34f9bcdd17ff

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Turn this off on beta, for now

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: We don't want to ship this feature as-is. It needs a minor change in bug 1782595, but since we also need to extend the feature to iframes (bug 1782596), it seems probably wiser to just turn it off in 104 and ship both things at the same time.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Prefs off feature to go to the previous behavior for at least one more cycle.
[String changes made/needed]: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9288036 [details] [diff] [review]
Turn this off on beta, for now

Approved for 104.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a67d1e512a86

Comment 11

[Dianna Smith [:diannaS]]

Attachment: 0001-Bug-1779457-Turn-a-pref-on-for-WPT-tests.patch

To address an expected failure https://treeherder.mozilla.org/logviewer?job_id=386266022&repo=mozilla-beta&lineNumber=5747

Comment 12

[Hamish Willee]

FF105 Docs for this can be tracked in https://github.com/mdn/content/issues/19449. We'll start a little closer to the release.

Emilio, is there a way of knowing when the discussion of the WG will make it into the specification? That way I can create a subfeature for this with a link to the specification in the browser compatibility data.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Well, someone needs to send a PR to the specification, or the editors will make the edits themselves. So no great way to know.

Comment 14

[Hamish Willee]

Thanks Emilio. I'm not sure an intent to accept this update to the spec is far enough along to mark this as "standard" in the browser compatibility data. So I'll probably have to mark as non-standard. If you create or see said PR can you please ping me.

Comment 15

[Brian Thomas Smith [bsmth]]

I've removed the dev-docs-needed keyword as there is documentation added for this in the following tracking issue on GitHub.