1779478 - Remove and replace some deprecated code on macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Stephen A Pohl [:spohl]]

We want to modernize our code base on macOS by removing and/or replacing the use of deprecated APIs. This is expected to take the form of several individual patches by gradually working through all the deprecation warnings at build time.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Bug 1779478: Replace the use of NSFindPboard and NSStringPboardType in our code base to modernize the code base and address deprecation warnings at build time. r=mstange

Depends on D153277

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Bug 1779478: Replace the deprecated NSCellStateValue with NSControlStateValue. r=mstange

Depends on D153635

Comment 4

[Stephen A Pohl [:spohl]]

Attachment: Bug 1779478: Replace the deprecated use of NSStatusItem.image with NSStatusItem.button.image. r=mstange

Depends on D153636

Comment 5

[Stephen A Pohl [:spohl]]

Attachment: Bug 1779478: Remove the deprecated use of NSCell's controlTint. r=mstange

Depends on D153637

Comment 6

[Stephen A Pohl [:spohl]]

Attachment: Bug 1779478: Replace the deprecated use of NSGraphicsContext's graphicsPort with CGContext. r=mstange

Depends on D153638

Comment 7

[Stephen A Pohl [:spohl]]

Rather than letting patches bitrot I'm going to land what we have so far and keep working on the remaining deprecation warnings. Setting leave-open.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfd7e060998e
Replace the use of NSFindPboard and NSStringPboardType in our code base to modernize the code base and address deprecation warnings at build time. r=mstange
https://hg.mozilla.org/integration/autoland/rev/4ae0ffc49b03
Replace the deprecated NSCellStateValue with NSControlStateValue. r=mstange
https://hg.mozilla.org/integration/autoland/rev/82515b99af37
Replace the deprecated use of NSStatusItem.image with NSStatusItem.button.image. r=mstange
https://hg.mozilla.org/integration/autoland/rev/b84e2b5933fe
Replace the deprecated use of NSGraphicsContext's graphicsPort with CGContext. r=mstange

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dfd7e060998e
https://hg.mozilla.org/mozilla-central/rev/4ae0ffc49b03
https://hg.mozilla.org/mozilla-central/rev/82515b99af37
https://hg.mozilla.org/mozilla-central/rev/b84e2b5933fe

Comment 10

[Mathew Hodson]

It looks like the commits in this bug caused bug 1822845, so bug bug 1822845 should be added to the Regressions field.

I think it would be easier to track if this bug was closed since patches have landed. The remaining patches can be moved to a new bug.