1779480 - Sync the UI feature tour callout state across instances of Firefox View

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

Ensure Firefox View feature tour shows the same state across any instance of Firefox View. When the user dismisses or advances on one instance, the change will be reflected in all instances.

When the value of the browser.firefoxView.featureTour changes, the tour should advance, or dismiss accordingly in all instances of Firefox View.

Comment 1

[Meg Viar [:mviar]]

Attachment: WIP: Bug 1779480 - Sync the UI feature tour callout state across instances of Firefox View

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1779480 - Sync the UI feature tour callout state across instances of Firefox View

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa0fb5af0a1
Sync the UI feature tour callout state across instances of Firefox View r=Mardak

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5fa0fb5af0a1

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

Hi, @Meg! I've started verifying this enhancement, and following the steps from the Test Plan, I noticed that the “browser.firefox-view.feature-tour" pref has the screen value empty after clicking the primary button from the last screen of the Firefox view feature tour. ( e.g. {"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"","complete":true})
Should I file a new issue for this behavior? Thanks!

Comment 7

[Meg Viar [:mviar]]

Hi @Simona! Thanks for flagging this. Conveniently, the typo was in my test plan and not in the code. I've updated the test plan and no need to file a new issue.

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

Thanks, @Meg for the reply!
I‘ve verified this enhancement using the latest Firefox Nightly 105.0a1 (Build ID: 20220810212956) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.

• The first screen is displayed below the "Switch seamlessly between devices" section.
• After navigating to the "about:firefoxview" page in a newly opened tab, the first screen is displayed as in the first opened tab.
• The second screen is displayed above the "Recently closed" section on both opened tabs after clicking the primary button from the first screen of the second opened tab.
• The second screen is displayed above the "Recently closed" section on both opened tabs after closing and reopening the browser.
• The third screen is displayed to the left of the "Independent Voices" section (on LTR builds) after clicking the primary button from the second screen of the first opened tab.
• The Firefox View feature tour is closed on both tabs after clicking the primary button from the third screen.
• The value of the "browser.firefox-view.feature-tour" pref in about:config is '{"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":","complete":true}' after clicking the primary button from the last screen of Firefox View feature tour.
• The Firefox View feature tour is no longer displayed after navigating again to the “about:firefoxview” page.