Properly handle libwebrtc ResidualEchoDetector change to injectable component or delete our pref
Categories
(Core :: WebRTC: Audio/Video, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: mjf, Assigned: pehrsons)
Details
Attachments
(1 file)
Upstream libwebrtc commit 498078ce28 "Remove deprecated webrtc::AudioProcessing::ResidualEchoDetector stats config" means we need to properly support the injectable component (added in upstream commit 03cb7e5a612) or do without the metrics. The bug detailing the reasoning behind the change is:
https://bugs.chromium.org/p/webrtc/issues/detail?id=11539
Important: This change does not in any way affect echo cancellation or standardized stats. The user audio experience is unchanged. Only non-standard stats are affected. Echo return loss metrics are unchanged. Residual echo likelihood {recent max} will no longer be computed by default.
If we decide those metrics are no longer useful, we can completely remove our pref:
media.getusermedia.residual_echo_enabled
Until a decision is made, this will be disabled in our code in MediaEngineWebRTCAudio.cpp.
|
Assignee | |
Comment 1•2 years ago
|
||
Per the upstream bug they used to always run audio input with audio processing, whether it was processing or not, for the sake of statistics. The residual echo detector was run just to compute statistics and is completely separate from the echo canceller. We don't need it.
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Comment 3•2 years ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:pehrsons, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•