1779517 - Screenshot malfunctions if site CSS has max-width set for iframe

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P2)

Description

[SiriusStarr]

Attachment: 2022-07-13_18-18.png

Steps to reproduce:

Attempt to take a screenshot (e.g. by Ctrl+Shift+S) on a website with the max-width property set for the iframe element.

An extremely simple website illustrating this is available here: https://siriusstarr.github.io/firefox-screenshot-bug/
(source at https://github.com/SiriusStarr/firefox-screenshot-bug/blob/main/index.html )

Actual results:

The colored overlay that allows one to take a screenshot is clamped to the left edge of the screen and extends only by the value of max-width, rendering it impossible to screenshot parts of the website further right than that.

Expected results:

The behavior of Firefox screenshots should not be subject to CSS on the page.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Peter Magyari (Desktop QA)]

Reproducible on MacOS 11 and Windows 10.

I'm setting the flags accordingly.

Thank you for reporting!

Comment 3

[Sam Foster [:sfoster] (he/him)]

Thanks for the report, this should be a straightforward fix.

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1779517 - Set max width and height for screenshots iframes. r=sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88827c9fe38a
Set max width and height for screenshots iframes. r=sfoster

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/88827c9fe38a

Comment 7

[Peter Magyari (Desktop QA)]

I have verified the fix on Windows 10 and MacOS 11 using Firefox Nightly 105.0a1 (20220727214405).

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Given how late we are in the cycle and the open regression bug, we should probably not uplift this to 104.