Closed Bug 1779562 Opened 4 years ago Closed 4 years ago

Collect IOUtils caller information in crashes in release populations

Categories

(Toolkit Graveyard :: OS.File, task)

Tracking

(firefox103 fixed, firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox103 --- fixed
firefox104 --- fixed

People

(Reporter: beth, Assigned: beth)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → brennie
Status: NEW → ASSIGNED
Attached file data-review.md
Attachment #9285472 - Flags: data-review?(chutten)

Comment on attachment 9285472 [details]
data-review.md

PRELIMINARY NOTES:
The answer to Q1 should be read as

When crashes are caused by using IOUtils (a parent-process only API) in non-parent processes, what was the JS caller of the API.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is based on Crash Reports so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Barret Rennie is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9285472 - Flags: data-review?(chutten) → data-review+
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da3aa5318fbd Always perform parent process assertion in IOUtils methods r=Gijs

Comment on attachment 9285471 [details]
Bug 1779562 - Always perform parent process assertion in IOUtils methods r?nika,kmag

Beta/Release Uplift Approval Request

  • User impact if declined: The crash telemetry added in 1778553 was limited to pre-release populations, so we won't have any insights into crashes in beta and release and won't be able to uplift fixes.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is not risky. This changes the location of a crash in late beta / release to one where we have annotations that point to the root cause.
  • String changes made/needed:
  • Is Android affected?: Unknown
Attachment #9285471 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

Comment on attachment 9285471 [details]
Bug 1779562 - Always perform parent process assertion in IOUtils methods r?nika,kmag

Approved beta uplift request, available on the beta channel with 103.0 RC1.

Attachment #9285471 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: