1779574 - IOCrash: Utils can only be used in the parent process. Called from resource://devtools/shared/DevToolsUtils.js:673:33.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Barret Rennie [:barret] (they/them)]

Crash report: https://crash-stats.mozilla.org/report/index/b2360071-7901-4fb8-844a-4859f0220714

MOZ_CRASH Reason: IOUtils can only be used in the parent process. Called from resource://devtools/shared/DevToolsUtils.js:673:33.

Top 10 frames of crashing thread:

0 XUL mozilla::dom::AssertParentProcessWithCallerLocation dom/system/IOUtils.cpp:303
1 XUL mozilla::dom::IOUtils::Read dom/system/IOUtils.cpp:363
2 XUL mozilla::dom::IOUtils_Binding::read dom/bindings/IOUtilsBinding.cpp:1276
3 XUL mozilla::dom::StaticMethodPromiseWrapper dom/bindings/BindingUtils.cpp:3324
4 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:508
5 XUL Interpret js/src/vm/Interpreter.cpp:3325
6 XUL js::Call js/src/vm/Interpreter.cpp:606
7 XUL JS_CallFunctionValue js/src/vm/CallAndConstruct.cpp:53
8 XUL nsXPCWrappedJS::CallMethod js/xpconnect/src/XPCWrappedJSClass.cpp:981
9 XUL PrepareAndDispatch xpcom/reflect/xptcall/md/unix/xptcstubs_aarch64.cpp:190

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1779574 - Use OS.File to read empty files in DevTools content process r?gijs

Comment 2

[Barret Rennie [:barret] (they/them)]

Comment on attachment 9285486 [details]
Bug 1779574 - Use OS.File to read empty files in DevTools content process r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: This patch fixes a crash when opening the devtools Style Editor for an empty file: URI.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is not risky. This is a partial revert of bug 1771608, which has been confirmed as the source of a crash.
• String changes made/needed:
• Is Android affected?: No

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7bccb316c6f
Use OS.File to read empty files in DevTools content process r=Gijs

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/b7bccb316c6f

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9285486 [details]
Bug 1779574 - Use OS.File to read empty files in DevTools content process r?gijs

Approved beta uplift request, available on the beta channel with 103.0 RC1.

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/92f14bfbb013