Closed Bug 1779735 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34858 - Renamed from tentative now we know this works with WPT. Fixed eval-001

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34858 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34858
Details from upstream follow.

Mike Bremford <mike@bfo.com> wrote:

Renamed from tentative now we know this works with WPT. Fixed eval-001

Followup from https://github.com/web-platform-tests/wpt/pull/34673

WPT testing works as expected[1] so this PR

  • Fixes the reftest for gradient-eval-001 to use the correct RGB value
  • Adjusts gradient-eval-002 and adds several more tests for gradient interpolation as of the current draft of css-images
  1. https://wpt.fyi/results/css/css-images/gradient/gradient-eval-001.tentative.html?sha=f443641477&label=master&max-count=1 - which would have passed had I used the correct RGB value in the reftest.
PR 34858 applied with additional changes from upstream: 36555b974deaa29719e1a4bbe7e4088c4780e3cb, 0a54b8f96a6d1d8b68db8e14a785f377aa3402e1, c6278df45682be673fe2ff59eaeef07c760be20d, e80beb616a3bea5f452ad0f5856aa5d06cfc0809, d28ccff9623d9208ce7fe15bd4c3d1680a6aea67
Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests

Status Summary

Firefox

PASS: 8
FAIL: 1

Chrome

PASS: 8
FAIL: 1

Safari

PASS: 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c1078f2d35d
[wpt PR 34858] - New tests for gradient interpolation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/71988a1eac08
[wpt PR 34858] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8c1078f2d35d
https://hg.mozilla.org/mozilla-central/rev/71988a1eac08

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.