1779745 - Exporting Public Key fails from account settings

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Martin Giger [:freaktechnik]]

STR:

1. Select (TB generated) key in account manager e2ee settings
2. Choose "Export Public Key to File"
3. Choose a target location

Expected result:
The public key file is written

Actual result:
The file isn't written and the erro console contains the following error:

Uncaught (in promise) TypeError: idArrayMinimal is not iterable
    getMultiplePublicKeys chrome://openpgp/content/modules/RNP.jsm:3296
    extractPublicKeys chrome://openpgp/content/modules/keyRing.jsm:580
    openPgpExportPublicKey chrome://messenger/content/am-e2e.js:1360

Comment 1

[Magnus Melin [:mkmelin]]

I see that. From bug 1756015.

Comment 2

[Magnus Melin [:mkmelin]]

Sorry, rather bug 1629309.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1779745 - Fix exporting Public Key from account settings. r=kaie

Comment 4

[Kai Engert (:KaiE:)]

Thanks Magnus for the fix, will review shortly.

However, I wonder why I cannot reproduce yet, neither with 102.x nor with 104 daily.
Could it depend on properties of a key?
Could you please point me to a key that triggers this problem?

Comment 5

[Kai Engert (:KaiE:)]

ok sorry, I was using openpgp key manager (not account settings)

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 9285749 [details]
Bug 1779745 - Fix exporting Public Key from account settings. r=kaie

[Approval Request Comment]
Regression caused by (bug #): 1629309
User impact if declined: export feature broken
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ee722467f6f0
Fix exporting Public Key from account settings. r=kaie

Comment 8

[Wayne Mery (:wsmwk)]

This missed beta uplift, so it will appear in beta 104 with the next esr opportunity being 102.1.1

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9285749 [details]
Bug 1779745 - Fix exporting Public Key from account settings. r=kaie

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/668902c75e6c