Closed Bug 1779929 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34866 - Fix wpt test for css-generated text on inline element

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox106 fixed)

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 2 open bugs, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34866 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34866
Details from upstream follow.

Sohom <sohom.datta@learner.manipal.edu> wrote:

Fix wpt test for css-generated text on inline element

The wpt test for css-generated text on inline elements
was failing since the reported LCP was being triggered
for the next block-level ancestor as outlined in the
spec.

Fixed the test to account for the aggregation of LCP
entries at the next block-level ancestor.

Also prevent the test from timing out if no LCP entries
are found.

Bug: 1321377
Change-Id: I65f4eb9cae42e6d19e485983843d5f49d852423c
Reviewed-on: https://chromium-review.googlesource.com/3768264
WPT-Export-Revision: 5187ff37d97aea67fc3c3223bae1a7984197a824

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
PASS: 3

Safari

OK : 1
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /largest-contentful-paint/observe-css-generated-text.html [wpt.fyi]
    • CSS generated text is observable as a LargestContentfulPaint candidate: FAIL (Chrome: PASS, Safari: FAIL)
    • Text generated with CSS using content:attr() is observable as a LargestContentfulPaint candidate: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS generated text on a inline element is observable as a LargestContentfulPaint candidate: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67deb21460e2 [wpt PR 34866] - Fix wpt test for css-generated text on inline element, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.