1779977 - Crash in [@ mozilla::dom::ToJSValue | mozilla::dom::Promise::MaybeSomething<T>]

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/b71aeb0a-c21e-4d32-b94e-9e57a0220717

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (JS_GetPendingException(aCx, aValue))

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::ToJSValue dom/bindings/ToJSValue.cpp:57
1 xul.dll mozilla::dom::Promise::MaybeSomething<mozilla::ErrorResult> dom/promise/Promise.h:365
2 xul.dll mozilla::dom::WebTask::Run dom/webscheduling/WebTaskScheduler.cpp:113
3 xul.dll mozilla::dom::WebTaskMainThreadRunnable::Run dom/webscheduling/WebTaskSchedulerMainThread.cpp:20
4 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:851
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1205
6 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:85
7 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:373
8 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:355
9 xul.dll nsBaseAppShell::Run widget/nsBaseAppShell.cpp:150

Unclear if this is a real bug or just bad hardware given the volume appears low and the code hasn't changed in a while. Filing this to track behavior.

Comment 1

[Gabriele Svelto [:gsvelto]]

An interesting bit of information that suggests this could be indeed a valid issue: the vast majority of the crashes are happening on https://www.airbnb.ru/ with a few more on https://www.airbnb.co.in https://www.airbnb.es and https://www.airbnb.com

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Sean, does the crash stack ring any bell to you? Could it be a relevant issue in prioritized task scheduling API?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase for another .scheduler exception handling issue

I couldn't find yet the testcase for this issue, but there is another issue. The testcase requires a debug build to assert.
Because of
https://searchfox.org/mozilla-central/rev/15b656909e77d3048d4652b894f79a8c719b4b86/dom/webscheduling/WebTaskScheduler.cpp#112
we don't always handle the exception.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://searchfox.org/mozilla-central/rev/15b656909e77d3048d4652b894f79a8c719b4b86/dom/webscheduling/WebTaskScheduler.cpp#112 should definitely be removed. That way error handling looks reasonable. There might still be some other issue leading to this particular bug.

Filed bug 1780790 for that issue.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 5 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.