1779982 - Migrate places from ChromeUtils.import to ES6 Modules

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task)

Description

[Mark Banner (:standard8)]

We should migrate the jsm files under toolkit/components/places and browser/components/places to be es modules.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r?mak

Depends on D152002

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1779982 - Migrate toolkit/components/places and browser/components/places to ESM. r?mak

Depends on D152003

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1779982 - Migrate places consumers to use ESM imports directly. r?mak

Depends on D152004

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/267e08f3868a
Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak
https://hg.mozilla.org/integration/autoland/rev/088e5148c307
Migrate toolkit/components/places and browser/components/places to ESM. r=mak
https://hg.mozilla.org/integration/autoland/rev/d2d8530f3c4d
Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers

Comment 5

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for node newtab
Failure log for failed TV job on test_permmanager_migrate_7-8.js
Failure log for failed TV job on browser_newtab_trigger.js
Failure log for failed TV job on browser_default_bookmark_toolbar_visibility.js
Failure log for failed TV job on browser_all_files_referenced.js
Failure log for failed TV job on browser_ext_urlbar.js

Failure log for failed node newtab job on the backout push

Backout link

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5dbb1db6794
Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54079aaa1857
Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak
https://hg.mozilla.org/integration/autoland/rev/145212fd826d
Migrate toolkit/components/places and browser/components/places to ESM. r=mak
https://hg.mozilla.org/integration/autoland/rev/d4c69c956271
Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing doc generate failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/ccddb3f54bb2856112ddc411d85cd709393a8bbe

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd3c5f747ff0
Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak
https://hg.mozilla.org/integration/autoland/rev/ca4dc0498003
Migrate toolkit/components/places and browser/components/places to ESM. r=mak
https://hg.mozilla.org/integration/autoland/rev/45314ef92b64
Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd3c5f747ff0
https://hg.mozilla.org/mozilla-central/rev/ca4dc0498003
https://hg.mozilla.org/mozilla-central/rev/45314ef92b64