1780017 - Migrate address bar code to ES modules

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Mark Banner (:standard8)]

We should migrate the jsm files under browser/components/urlbar to be ES modules.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1780017 - Remove undefined export from UrlbarPrefs.jsm. r?adw

Depends on D152005

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1780017 - Migrate browser/components/urlbar to ESM. r?adw

Depends on D152055

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r?adw

Depends on D152056

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1780017 - Load Urlbar providers via importESModule. r?adw

Depends on D152057

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea9b3bf42ea1
Remove undefined export from UrlbarPrefs.jsm. r=adw
https://hg.mozilla.org/integration/autoland/rev/213ee5578e7c
Migrate browser/components/urlbar to ESM. r=adw
https://hg.mozilla.org/integration/autoland/rev/e21c85d61b91
Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/f33a58aa2f3f
Load Urlbar providers via importESModule. r=adw

Comment 6

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for node newtab
Failure log for failed TV job on test_permmanager_migrate_7-8.js
Failure log for failed TV job on browser_newtab_trigger.js
Failure log for failed TV job on browser_default_bookmark_toolbar_visibility.js
Failure log for failed TV job on browser_all_files_referenced.js
Failure log for failed TV job on browser_ext_urlbar.js

Failure log for failed node newtab job on the backout push

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e158fc41594b
Remove undefined export from UrlbarPrefs.jsm. r=adw
https://hg.mozilla.org/integration/autoland/rev/e668d7778d97
Migrate browser/components/urlbar to ESM. r=adw
https://hg.mozilla.org/integration/autoland/rev/ae6062c69aeb
Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/6f20b7e4b21b
Load Urlbar providers via importESModule. r=adw

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing doc generate failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/ccddb3f54bb2856112ddc411d85cd709393a8bbe

Push with failures

Failure log

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1780017 - Add mjs files to files that may be used for generating jsdocs. r?#firefox-source-docs-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78892b17c7ee
Add mjs files to files that may be used for generating jsdocs. r=firefox-source-docs-reviewers,ahal

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/78892b17c7ee

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a23c9e27f01
Remove undefined export from UrlbarPrefs.jsm. r=adw
https://hg.mozilla.org/integration/autoland/rev/a400cbe83084
Migrate browser/components/urlbar to ESM. r=adw
https://hg.mozilla.org/integration/autoland/rev/f448f044f028
Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/35abe35417a0
Load Urlbar providers via importESModule. r=adw

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser/base/content/test/performance/browser_preferences_usage.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb8ad931122559e1523cc7e53ae581f7886e3a19

Push with failures

Failure log

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1c0b375911f
Remove undefined export from UrlbarPrefs.jsm. r=adw
https://hg.mozilla.org/integration/autoland/rev/e89bd38c1d3f
Migrate browser/components/urlbar to ESM. r=adw
https://hg.mozilla.org/integration/autoland/rev/f66e30acaa44
Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/b63f86485323
Load Urlbar providers via importESModule. r=adw

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a1c0b375911f
https://hg.mozilla.org/mozilla-central/rev/e89bd38c1d3f
https://hg.mozilla.org/mozilla-central/rev/f66e30acaa44
https://hg.mozilla.org/mozilla-central/rev/b63f86485323