Closed Bug 1780116 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 34884 - Only use asyncio.wait_for in bidi navigation tests which expect a timeout

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34884 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34884
Details from upstream follow.

Julian Descottes <jdescottes@mozilla.com> wrote:

Only use asyncio.wait_for in bidi navigation tests which expect a timeout

Additional background in https://bugzilla.mozilla.org/show_bug.cgi?id=1764661#c10.

The current tests in navigate/wait.py assert navigations which might timeout depending on the configuration tested.
We race the navigation against an asyncio.wait_for with a 1s delay. If the navigation is supposed to succeed, we assume it will resolve faster than 1s. However, on some slow platforms in our CI, this is not consistent and the test is intermittently failing.

So the proposal here is to only race against asyncio.wait_for when we expect the navigation to timeout. If we expect the navigation to succeed, we wait as long as needed.

Component: web-platform-tests → geckodriver

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
PASS : 12

Chrome

TIMEOUT: 1

Safari

OK : 1
ERROR : 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3b562638588
[wpt PR 34884] - Only use asyncio.wait_for in bidi navigation tests which expect a timeout, a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.