1780159 - UnboundLocalError: local variable 'cmd_and_path' referenced before assignment

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Petr Sumbera]

Steps to reproduce:

Build on Solaris fails with:

 0:09.31 checking for host system type... sparc64-sun-solaris2.11
 0:09.31 checking for target system type... sparc64-sun-solaris2.11
 0:11.94 checking whether cross compiling... no
 0:13.10 Traceback (most recent call last):
 0:13.10   File "/builds2/psumbera/mozilla-central-build/configure.py", line 349, in <module>
 0:13.10     sys.exit(main(sys.argv))
 0:13.11   File "/builds2/psumbera/mozilla-central-build/configure.py", line 131, in main
 0:13.11     sandbox.run(os.path.join(os.path.dirname(__file__), "moz.configure"))
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 506, in run
 0:13.11     self.include_file(path)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 497, in include_file
 0:13.11     exec_(code, self)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/util.py", line 57, in exec_
 0:13.11     exec(object, globals, locals)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/moz.configure", line 368, in <module>
 0:13.11     @imports(_from="mozbuild.backend.clangd", _import="find_vscode_cmd")
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 849, in decorator
 0:13.11     depends = DependsFunction(self, func, dependencies, when=when)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 137, in __init__
 0:13.11     sandbox._value_for(self)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 618, in _value_for
 0:13.11     return self._value_for_depends(obj)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/util.py", line 1061, in method_call
 0:13.11     cache[args] = self.func(instance, *args)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 627, in _value_for_depends
 0:13.11     value = obj.result()
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/util.py", line 1061, in method_call
 0:13.11     cache[args] = self.func(instance, *args)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 163, in result
 0:13.11     return self._func(*resolved_args)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/configure/__init__.py", line 1310, in wrapped
 0:13.11     return new_func(*args, **kwargs)
 0:13.11   File "/builds2/psumbera/mozilla-central-build/moz.configure", line 401, in build_backend_defaults
 0:13.11     and find_vscode_cmd()
 0:13.11   File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/backend/clangd.py", line 81, in find_vscode_cmd
 0:13.11     for element in cmd_and_path:
 0:13.11 UnboundLocalError: local variable 'cmd_and_path' referenced before assignment
 Config object not found by mach.
*** Fix above errors and then restart with "./mach build"

The first bad revision is:
changeset: 624261:3a19960fa879
user: Gijs Kruitbosch <[e-mail]>
date: Mon Jul 18 06:14:23 2022 -0700
description:
Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium

Differential Revision: https://phabricator.services.mozilla.com/D150147

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1773520

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:Gijs, since you are the author of the regressor, bug 1773520, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1780159 - add a default value for cmd_and_path in vscode detection for non-Windows/macOS/Linux OSes, r?andi

Comment 5

[:Gijs (he/him)]

I don't have access to Solaris, could you check if the attached patch fixes the issue for you? You can use moz-phab patch, or download and apply https://d2mfgivbiy2fiw.cloudfront.net/file/data/57cfjirkyo7pgugckwex/PHID-FILE-kiafash5byl7o7tf6jvm/D152159.diff .

Comment 6

[Petr Sumbera]

I can confirm that the patch resolves the issue. Thank you!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae3b34336c35
add a default value for cmd_and_path in vscode detection for non-Windows/macOS/Linux OSes, r=andi,firefox-build-system-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ae3b34336c35