1780222 - test-info manifest-conditions artifact should differentiate between multiple line conditions

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in recent years we support conditions on multiple lines for manifestparser .ini test manifests. Previously conditions were restricted to a single line, such as:
skip-if = debug || asan || tsan || ccov

now this can look like:

skip-if =
  debug
  asan
  tsan
  ccov

each line is a unique condition, and I would like to consider them separate manifest conditions, not combine them to a single condition. What happens in the test-info-all task is we generate an artifact. This has entries like:
((debug || asan) && os == "win" && bits == 64) os == 'linux' && bits == 64

really this should be two entries:

 ((debug || asan) && os == "win" && bits == 64)
 os == 'linux' && bits == 64

I admit to not knowing the consumers of this file, so possibly I am overlooking an important use case.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1780222 - annotation report should show multi line conditions properly. r=gbrown!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e1216cbfd05
annotation report should show multi line conditions properly. r=gbrown,webdriver-reviewers,whimboo

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7e1216cbfd05