Closed Bug 1780236 Opened 2 years ago Closed 2 years ago

Spacing between Tab pickup and Recently closed headers and supporting content different from design files

Categories

(Firefox :: Firefox View, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox104 --- disabled
firefox106 --- verified
firefox107 --- verified

People

(Reporter: jberman, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] [Interface])

Attachments

(3 files)

Actual: Spacing between headers and supporting copy is 15 px
Expected: Spacing between headers and supporting copy is 4 px

(Tab Pickup and Recently closed headers and supporting copy)

Summary: Firefox View → Spacing between Tab pickup and Recently closed headers and supporting content different from design files
Component: General → Firefox View

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sfoster)
Severity: -- → S3
Flags: needinfo?(sfoster)
Priority: -- → P3
Depends on: 1786615
No longer depends on: 1786615
Keywords: perf:frontend
Keywords: perf:frontend
Whiteboard: [fidefe-2022-mr1-firefox-view] → [fidefe-2022-mr1-firefox-view] [Interface]
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

Its hard to get the numbers lined up exactly with the figma mockup because we have margins on the heading and the description. This reduces the top margin on the description to 2px. I could go to 0 but that started to look a little cramped to me.

Flags: needinfo?(jberman)

Sam and I collaborated and I built off his work to create a figma file that shows how we can get a little closer to the original comps. This is a suggestion/starting point for how we can adjust margins to get to the originally spec'd spacing but open to feedback. https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=13165%3A154105

Flags: needinfo?(jberman)
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7856257e7ff8
Tighen up the spacing between section header, description and lists in fx-view. r=sclements
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Should this get uplifted to 106?

Flags: needinfo?(sfoster)

Comment on attachment 9295668 [details]
Bug 1780236 - Tighen up the spacing between section header, description and lists in fx-view. r?sclements!

Beta/Release Uplift Approval Request

  • User impact if declined: Spacing between items on firefox-view page is not as designed
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Compare vertical spacing of headings and description text looks similar to the screenshot in attachment 9295637 [details].
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only cosmetic patch that applies to the firefox-view page.
  • String changes made/needed: None
  • Is Android affected?: No
Flags: needinfo?(sfoster)
Attachment #9295668 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

This is verified fixed using Firefox 107.0a1 (BuildId:20220927213841) on Windows 10 64bit, macOS 11 and Ubuntu 22.

Leaving the qe-verify+ flag until this gets uplifted and verified.

Comment on attachment 9295668 [details]
Bug 1780236 - Tighen up the spacing between section header, description and lists in fx-view. r?sclements!

Approved for 106.0b6, thanks.

Attachment #9295668 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This is verified fixed using Firefox 106.0b6 (BuildId:20220929195234) on Windows 10 64bit, Ubuntu 22 and macOS 11

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: